Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Show survey for users that reached second slide #5101

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T380433

Notes

  • Adds a local flag to indicate if the user reached the second slide
  • User is then eligible to see the survey
  • Survey display logic remains as-is, is not shown again if user already seen
  • We're checking for the slide of index 1, which the second item in the in 0-based array it's stored

Test Steps

  1. Fresh install the app, go to YiR
  2. Go to the second slide, return to the first
  3. Leave YiR
  4. You should see the survey
  5. Fresh install the app again, go to YiR
  6. Go to the last slide, tap finish
  7. You should see the survey
  8. Fresh install the app again, go to YiR
  9. Leave YiR at any point from the 2nd slide, you should see the survey
  10. Enter and leave YiR, the survey should no be displayed

@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team November 29, 2024 14:27
@l-olson1214 l-olson1214 requested review from l-olson1214 and removed request for tonisevener December 4, 2024 15:14
@l-olson1214 l-olson1214 merged commit a166fe5 into main Dec 4, 2024
4 checks passed
@l-olson1214 l-olson1214 deleted the show-survey-yir branch December 4, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy