Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Insert Image wizard mediawiki links to consider device language #5106

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Update Insert Image wizard mediawiki links to consider device language #5106

merged 3 commits into from
Dec 4, 2024

Conversation

mazevedofs
Copy link
Collaborator

Phabricator: https://phabricator.wikimedia.org/T377887

Notes

  • Adds Special:MyLanguage and uselang= query items to mediawiki URLS to redirect to translated versions if available
  • It falls back to English if translation is not available

Test Steps

  1. Set device language to Spanish
  2. Go to the insert image wizard, and tap the learn more links
  3. They should open in the Spanish translation of the page
  4. Set device language to German (or other languages without translations)
  5. Link should open in English

@mazevedofs mazevedofs requested review from a team and tonisevener and removed request for a team December 2, 2024 19:11
tonisevener
tonisevener approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do notice the scroll is slightly too far - you have to scroll a little bit up to see the section title. Since it's a small amount, I suspect it may be related to our custom navigation bar. Going to merge and see if it's fixed in the system nav bar branch.

@tonisevener tonisevener merged commit 797dcdf into main Dec 4, 2024
4 checks passed
@tonisevener tonisevener deleted the add-image-page branch December 4, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazevedofs @tonisevener
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy