Improved logic of Boyer Moore & added few edge cases in test #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamfiset
reviewed
Jun 4, 2020
src/main/java/com/williamfiset/algorithms/strings/BoyerMooreStringSearch.java
Outdated
Show resolved
Hide resolved
williamfiset
reviewed
Jun 4, 2020
src/test/java/com/williamfiset/algorithms/strings/BoyerMooreStringSearchTest.java
Show resolved
Hide resolved
sharoha
commented
Jun 7, 2020
src/test/java/com/williamfiset/algorithms/strings/BoyerMooreStringSearchTest.java
Show resolved
Hide resolved
williamfiset
requested changes
Jun 7, 2020
src/test/java/com/williamfiset/algorithms/strings/BoyerMooreStringSearchTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/williamfiset/algorithms/strings/BoyerMooreStringSearchTest.java
Show resolved
Hide resolved
|
Rohan, thank you for adding tests and fixing this implementation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #174 for edge cases. It uses Bad Character Heuristic to find the matches.