Change submit button while creating Lexeme #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the button’s label, and disable it, while the Lexeme is being created. When it’s done, reenable the button and change the label back. Note that the button may still appear to be enabled when it’s clicked with the mouse (instead of another way to submit the form, like pressing Enter in the lemma input); this requires wmde/wikit#584 to fix. In the tests, after rejecting the lexemeCreator promise, we apparently need to wait for the next Vue tick six times. I don’t know why, but five isn’t enough. I’m sorry. Bug: T304511
micgro42
reviewed
May 23, 2022
micgro42
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the button’s label, and disable it, while the Lexeme is being created. When it’s done, reenable the button and change the label back.
Note that the button may still appear to be enabled when it’s clicked with the mouse (instead of another way to submit the form, like pressing Enter in the lemma input); this requires wmde/wikit#584 to fix.
In the tests, after rejecting the lexemeCreator promise, we apparently need to wait for the next Vue tick six times. I don’t know why, but five isn’t enough. I’m sorry.
Bug: T304511