api accepts url params and additional keyword args for requests module #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the url params that are sent to Woo-Commerce are a closed box. They should be exposed outside of the function. Additionally, there are cases where a developer needs to pass additional parameters to the requests library. These should also be exposed outside of the function. This pull request simply achieves these things.
|
I really like how simple this package is, so I don't know if it fits in with your vision... But would you be interested in adding a "getPaged" method to the API class? If so, I can make a pull request once we get this one sorted out. |
This was referenced Apr 16, 2018
|
Fixes #37 |
|
After opening this pull request originally I found out that the code would not work when extra params are used with OAuth. I updated the code just now to what should work from memory. Unfortunately I don't have access to a woo shop to test my work today. I can test this either this weekend or next. |
|
Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the url params that are sent to Woo-Commerce are a closed box.
They should be exposed outside of the function. Additionally, there are
cases where a developer needs to pass additional parameters to the
requests library. These should also be exposed outside of the function.
I've been meaning to make a pull request for this. I have previously
sub-classed the woocommerce.api.API object in order to do this and
think it would be helpful to others who like me need to do more
complicated requests.