Feature: support sequence and mapping input #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjpieters
commented
Jan 7, 2025
| Mapping[str, str], | ||
| Mapping[bytes, bytes], | ||
| Sequence[tuple[str, str]], | ||
| Sequence[tuple[bytes, bytes]], | ||
| ] | ||
|
|
||
| CookieTypes: TypeAlias = Union[httpx.Cookies, dict[str, str], list[tuple[str, str]]] |
There was a problem hiding this comment.
Note: The httpx methods that accept CookieTypes define these as dict and list too, so these can't be broadened.
|
Thanks for your PR 👍🏻 . I may need to spend some time reviewing all the changes. |
yanyongyu
reviewed
Jan 8, 2025
a3c57f7 to
0e552b4
Compare
- Most `dict` parameters can be any mapping type - Most `list` parameters can be any iterable, or if stored, any sequence
0e552b4 to
8bdc1d4
Compare
yanyongyu
reviewed
Jan 10, 2025
yanyongyu
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dictparameters can be any mapping typelistparameters can be any iterable, or if stored, any sequenceThese changes make it a lot easier to use, say,
TypedDictto define GraphQL query input values.Also see the Arguments and Return Types section in the Typing Best Practices chapter of the Python static typing documentation.