Skip to content

Use slash as path separator on Windows #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

Use slash as path separator on Windows #12

merged 1 commit into from
Aug 6, 2024

Conversation

vain0x
Copy link
Contributor

@vain0x vain0x commented Aug 6, 2024

This PR fixes the issue that inserted path contains \ (backslash) instead of / on Windows.

For example:

// latest (v0.3.2)
import * as AnotherLogics from "./logics\AnotherLogics";

// fixed
import * as AnotherLogics from "./logics/AnotherLogics";

yukukotani
yukukotani requested changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I believe you can just replace path.relative by path.posix.relative instead of manipulating string. Could you try it?

@vain0x
Copy link
Contributor Author

vain0x commented Aug 6, 2024

Thanks! I changed the PR.

yukukotani
yukukotani approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@yukukotani yukukotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yukukotani yukukotani merged commit f86eb2a into yukukotani:master Aug 6, 2024
@yukukotani
Copy link
Owner

Released in https://github.com/yukukotani/typescript-plugin-namespace-import/releases/tag/v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukukotani yukukotani yukukotani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vain0x @yukukotani
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy