Prevent lines containing ... being excluded from coverage #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-v-b
reviewed
Jul 25, 2025
| exclude_lines = [ | ||
| "pragma: no cover", | ||
| "if TYPE_CHECKING:", | ||
| "pragma: ${PY_MAJOR_VERSION} no cover", |
There was a problem hiding this comment.
is the pragma: no cover directive handled automatically with the new version of coverage?
There was a problem hiding this comment.
Yes - it's listed in the default exclusions. I also checked locally, and lines tagged with # pragma: no cover seemed to be excluded correctly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3298 +/- ##
==========================================
+ Coverage 59.69% 60.68% +0.99%
==========================================
Files 78 78
Lines 8694 9356 +662
==========================================
+ Hits 5190 5678 +488
- Misses 3504 3678 +174 🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Jul 25, 2025
|
thanks @K-Meech! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3297
This PR prevents lines that contain
...(alongside other text) from being excluded from coverage - see the corresponding issue #3297 for more details.I swapped from
exclude_linestoexclude_also, as this allows the default exclusions to be kept + added to, rather than completely overwritten (see coverage docs). Sincecoverageversion7.10.0the default exclusions have included lines with...by itself.TODO:
docs/user-guide/*.rstchanges/