Page MenuHomePhabricator
Create Task
Maniphest T107174

Add an API action to just change content model
Closed, ResolvedPublic
Actions

Description

action=changecontentmodel to accompany the new Special:ChangeContentModel (rMWfa31bf1675af: Add Special:ChangeContentModel). We already allow people to change content model via action=edit, this would let them do it without re-sending the page text.

Details

SubjectRepoBranchLines +/-
Add a ContentModelChange helper, and an api module that uses itmediawiki/coremaster+1 K -99
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Jul 28 2015, 5:53 PM
Legoktm raised the priority of this task from to Medium.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MediaWiki-Action-API, MediaWiki-ContentHandler.
Legoktm added subscribers: Legoktm, Anomie.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2015, 5:53 PM
Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Jul 28 2015, 6:01 PM
DannyS712 claimed this task.Aug 29 2019, 8:31 AM
DannyS712 lowered the priority of this task from Medium to Low.
Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptAug 29 2019, 8:31 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.Aug 29 2019, 8:31 AM
daniel moved this task from Inbox to Feature Requests to Review on the Platform Engineering board.Aug 29 2019, 10:11 AM
DannyS712 added a comment.Dec 8 2019, 3:06 AM

Is Platform Engineering okay with this addition?

Anomie added a comment.Dec 13 2019, 7:16 PM

Seems reasonable and uncontroversial to me, I'd review and merge a patch without asking for additional consensus. I don't know what the actual PMs might think.

DannyS712 added a comment.Jan 11 2020, 1:41 AM
In T107174#5740187, @Anomie wrote:

Seems reasonable and uncontroversial to me, I'd review and merge a patch without asking for additional consensus. I don't know what the actual PMs might think.

Thanks. I've written most of it, just trying to expand the tests to bit more (currently at 84% coverage)

gerritbot added a comment.Jan 11 2020, 11:49 PM

Change 563701 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add an api module to edit the content model of a page

https://gerrit.wikimedia.org/r/563701

gerritbot added a project: Patch-For-Review.Jan 11 2020, 11:49 PM
DannyS712 moved this task from Needs Code to Needs Review on the MediaWiki-Action-API board.Jan 11 2020, 11:54 PM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jan 13 2020, 6:28 PM
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Feb 11 2020, 3:49 PM
DannyS712 added a comment.Feb 23 2020, 4:25 AM

@Anomie I've eliminated the duplication and added lots of tests. Can you take another look?

• WDoranWMF moved this task from External Code Review In Progress to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.Mar 3 2020, 8:35 PM
Anomie moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Mar 11 2020, 7:24 PM
Anomie moved this task from External Code Review In Progress to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Mar 11 2020, 8:09 PM
gerritbot added a comment.Mar 11 2020, 10:10 PM

Change 563701 merged by jenkins-bot:
[mediawiki/core@master] Add a ContentModelChange helper, and an api module that uses it

https://gerrit.wikimedia.org/r/563701

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2020, 10:11 PM
DannyS712 closed this task as Resolved.Mar 11 2020, 10:54 PM

confirmed, see https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=history

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 11 2020, 11:00 PM
DannyS712 added a project: User-notice.Mar 12 2020, 6:43 PM

Should be included in tech news

DannyS712 moved this task from To Triage to Announce in next Tech/News on the User-notice board.Mar 12 2020, 6:44 PM
DannyS712 moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Mar 12 2020, 6:46 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 19 2020, 6:16 AM
DannyS712 mentioned this in T253080: Add new ContentModelChangeFactory interface, implement with PageCommandFactory.May 18 2020, 11:26 PM
DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.May 27 2020, 8:35 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Reedy mentioned this in T270988: CVE-2021-30155: Titleblacklist didn't prevent creation of pages by Special:ChangeContentModel when a rule was met.Apr 4 2021, 11:36 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy