Page MenuHomePhabricator
Create Task
Maniphest T180207

Convert "Show diff" part of Special:Undelete to OOUI
Closed, ResolvedPublic
Actions

Assigned To
Albert221
Authored By
Nirmos
Nov 10 2017, 10:39 AM
Tags
Referenced Files
F11178405: image.png
Dec 4 2017, 5:22 PM
F11177835: image.png
Dec 4 2017, 4:42 PM
F11053989: Screenshot from 2017-11-28 20-53-33.png
Nov 28 2017, 7:55 PM
Subscribers
Aklapper
Albert221
Florian
Framawiki
gerritbot
Nirmos
• Prtksxna
View All 10 Subscribers

Description

On Special:Undelete, there are two buttons for preview and diff. These buttons do not have any space between them and the whole page does not use OOUI, like all other UI parts on this special page.

Acceptance criteria:

  • The funtionality of the page has not changed
  • The "View difference" page of Special:Undelete is converted to use OOUI.

The code for this special page is at https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/SpecialUndelete.php and the buttons are defined in showRevision on lines 473 to 486.

Details

SubjectRepoBranchLines +/-
Replace some Special:Undelete button with OOUI onesmediawiki/coremaster+20 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nirmos created this task.Nov 10 2017, 10:39 AM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptNov 10 2017, 10:39 AM
Nirmos triaged this task as Lowest priority.Nov 10 2017, 10:39 AM
rosalieper added a project: Google-Code-in-2017.Nov 10 2017, 4:42 PM
rosalieper subscribed.

I will mentor this for GCI/17

Florian moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Nov 14 2017, 6:43 PM
Florian subscribed.

Imported as: https://codein.withgoogle.com/dashboard/tasks/5668801058177024/

However, the whole UI on that page is not really aligned with the other UI elements of the Special:Undelete page, which uses OOUI. So, what do you think of using this task (which can still be a GCI task I think), to convert the interface to use OOUI. That should be pretty simple I think, too :)

rosalieper added a comment.Nov 16 2017, 7:42 AM

I think that's a good Idea

Florian renamed this task from Add margin between buttons on Special:Undelete to Convert "Show diff" part of Special:Undelete to OOUI.Nov 16 2017, 5:10 PM
Florian updated the task description. (Show Details)
Florian added a parent task: T107037: Convert all MW core special pages to OOUI.

I also updated the GCI task :)

Aklapper added a comment.Nov 28 2017, 7:55 PM

Screenshot (using MediaWiki's "Vector" skin):

Screenshot from 2017-11-28 20-53-33.png (501×1 px, 38 KB)

• Prtksxna subscribed.Dec 4 2017, 5:28 AM
Albert221 subscribed.Dec 4 2017, 4:42 PM

I replaced these two buttons and the textarea to OOUI, I'm pushing it to Gerrit. If something's wrong, tell me!

image.png (773×978 px, 55 KB)

gerritbot subscribed.Dec 4 2017, 4:44 PM

Change 395037 had a related patch set uploaded (by Albert221; owner: Albert221):
[mediawiki/core@master] Replace some Special:Undelete button with OOUI ones

https://gerrit.wikimedia.org/r/395037

gerritbot added a project: Patch-For-Review.Dec 4 2017, 4:44 PM
Albert221 added a comment.Dec 4 2017, 5:22 PM

Update:

image.png (570×816 px, 20 KB)

Framawiki subscribed.Dec 4 2017, 6:14 PM
gerritbot added a comment.Dec 4 2017, 6:25 PM

Change 395037 merged by jenkins-bot:
[mediawiki/core@master] Replace some Special:Undelete button with OOUI ones

https://gerrit.wikimedia.org/r/395037

Albert221 closed this task as Resolved.Dec 4 2017, 6:27 PM
Albert221 claimed this task.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 4 2017, 7:00 PM
Volker_E removed a project: Patch-For-Review.Dec 5 2017, 2:54 AM
Bawolff mentioned this in T182426: OOUI MultilineTextInputWidget textboxes are grey in Monobook (Apex) but not in Vector (WikimediaUI theme).Dec 9 2017, 1:35 AM
Volker_E subscribed.Apr 17 2018, 5:25 AM

Was partly reverted in T182398: Special:Undelete contains egregious white space after OOUI update

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy