Description

NOTE: banner will be split out by Olga into new task: T228516

Special:RecentChanges (as well as watchlist) have an option to view "grouped" changes.

Screen Shot 2019-07-17 at 15.10.11.png (696×824 px, 89 KB)

This option reformats the list and groups results by page.

Screen Shot 2019-07-17 at 15.12.23.png (328×1 px, 163 KB)

This option is ill-suited for mobile because it uses a table-based layout (as well as hard-coded whitespace characters 🤨), which cannot be modified to fit on mobile devices.

Therefore, the "group results by page" option should be disabled on mobile.

But by disabling this option on mobile, we are also overriding a user preference 😱

Screen Shot 2019-07-17 at 15.22.33.png (950×1 px, 155 KB)

To ensure users who have this option enabled (surely advanced editors) aren't surprised or think it's broken, we are going to display a banner on the page informing users that grouped results have been disabled on mobile. (another task)

Developer notes

The "grouped" view is referred to as EnhancedChangesList.php in MediaWiki core. The ChangesList.php class in core provides a FetchChangesList hook on which we can use to override the instantiation of EnhancedChangesList. We should place this hook in mobileFrontend, and it should do two things: 1. $list = new OldChangesList( $context) 2. return false.

QA steps

Environment: beta cluster.

The goal of this task is to ensure that the "grouped" view on the Recent Changes page is not accessible in the Minerva skin. The "grouped view" can be accessed in 3 different ways:

The url parameter -- On the Recent changes page, add enhanced=1 as a url parameter. The presentation of the results should not change.
The advanced filters checkbox (screenshot above). -- These filters aren't available on mobile mode yet, but you can add the &useskin=minerva url param on desktop to trigger the Minerva skin, then on the recent changes page, clicking the checkbox in the filters should do nothing.
Enabling a user preference (screenshot also above). -- As a logged in user, enable this user preference. Then on the Recent changes page, the results should still not be grouped.

AC

~~The option to "group results by page" is removed from the Recent changes filters~~ ( This AC is blocked on T225499)
If a user has the "group changes by page" preference selected, we still show the "old" results on mobile
If the url param enhanced=1 is entered in the RecentChanges page, we still show the "old" results on mobile.

Subject	Repo	Branch	Lines +/-
Limit Recent Changes disable-table mode to Minerva skin	mediawiki/skins/MinervaNeue	wmf/1.34.0-wmf.16	+7 -5
Limit Recent Changes disable-table mode to Minerva skin	mediawiki/skins/MinervaNeue	master	+7 -5
Disable the recent changes table-based layout on Minerva	mediawiki/skins/MinervaNeue	master	+20 -0
ChangesList: Add $groups parameter to FetchChangesList hook	mediawiki/core	master	+2 -1

Event Timeline

Jdrewniak created this task.Jul 17 2019, 1:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2019, 1:52 PM

ovasileva triaged this task as High priority.Jul 17 2019, 2:22 PM

ovasileva assigned this task to Jdlrobson.Jul 17 2019, 3:20 PM

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

Approach with hook might not work on translate.wiki. The translate wiki is using https://www.mediawiki.org/wiki/Extension:CleanChanges extension, which listens to the same hook, and overrides the $list with NCL, EnhancedChangesList or OldChangesList. Most probably code has to accommodate how CleanChanges extension works.

Note: Looks like translate.wiki doesn't have MobileFrontend, so it's not a problem.

Estimate is for disabling the group list only, @ovasileva to split off the banner into a separate task

ovasileva moved this task from Needs Prioritization to Upcoming on the Web-Team-Backlog board.Jul 17 2019, 4:34 PM

Jdrewniak mentioned this in T224432: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode.Jul 18 2019, 1:06 PM

Change 524031 had a related patch set uploaded (by Niedzielski; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Disable the recent changes table-based layout on Minerva

https://gerrit.wikimedia.org/r/524031

gerritbot added a project: Patch-For-Review.Jul 18 2019, 1:48 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Web-Team-Backlog.Jul 18 2019, 3:12 PM

Let's use

<div class="warningbox">
	-----COPY FOR NOTICE-----
</div>

@ovasileva copy ^

In T228280#5346410, @Nirzar wrote:
Let's use
<div class="warningbox">
	-----COPY FOR NOTICE-----
</div>
@ovasileva copy ^

"Unfortunately, grouping results by page is not available in Advanced mode. If you would like to use the group by page feature, please visit the desktop site. "

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 18 2019, 7:32 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdlrobson updated the task description. (Show Details)Jul 18 2019, 10:45 PM

Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 19 2019, 12:38 AM

ovasileva updated the task description. (Show Details)Jul 19 2019, 2:02 PM

Change 524533 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] FetchChangesList is now passed groups

https://gerrit.wikimedia.org/r/524533

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 19 2019, 2:48 PM

Jdlrobson updated the task description. (Show Details)Jul 19 2019, 3:50 PM

Change 524533 merged by jenkins-bot:
[mediawiki/core@master] ChangesList: Add $groups parameter to FetchChangesList hook

https://gerrit.wikimedia.org/r/524533

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 22 2019, 10:00 PM

Change 524031 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Disable the recent changes table-based layout on Minerva

https://gerrit.wikimedia.org/r/524031

Restricted Repository Identity mentioned this in rSKIN1c9798808c14: Update git submodules.Jul 23 2019, 6:13 PM

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.15; 2019-07-23).Jul 23 2019, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2019, 7:10 PM

Jdrewniak reassigned this task from Jdlrobson to Edtadros.Jul 23 2019, 7:34 PM

Jdrewniak moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Jdrewniak added a subscriber: Jdlrobson.

Jdrewniak updated the task description. (Show Details)Jul 23 2019, 7:38 PM

@Jdrewniak where should I test this?

@Edtadros description updated. This should be live on the beta cluster :)

Jdrewniak reassigned this task from Jdrewniak to Edtadros.Jul 25 2019, 11:22 PM

This change also affects non-mobile views: I can no longer group recent changes on mediawiki.org (or the beta cluster), regardless of the value of the preference. I use Vector (on desktop - no mobile whatsoever).

If I look at https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/524031, it would make it seem that it is always disabled - regardless of the skin used. Since the hooks are executed unconditionally, they themselves need to check if the current skin is Minerva. That makes this a train blocker.

Jdlrobson raised the priority of this task from High to Unbreak Now!.Jul 31 2019, 6:29 PM

Jdlrobson moved this task from Needs QA to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJul 31 2019, 6:29 PM

Change 526748 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Limit Recent Changes disable-table mode to Minerva skin

https://gerrit.wikimedia.org/r/526748

gerritbot added a project: Patch-For-Review.Jul 31 2019, 6:36 PM

Jdlrobson added a parent task: T220741: 1.34.0-wmf.16 deployment blockers.Jul 31 2019, 6:37 PM

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.Jul 31 2019, 6:42 PM

brennen subscribed.Jul 31 2019, 6:53 PM

Change 526748 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Limit Recent Changes disable-table mode to Minerva skin

https://gerrit.wikimedia.org/r/526748

Restricted Repository Identity mentioned this in rSKIN3d5c92cb71a7: Update git submodules.Jul 31 2019, 7:01 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 7:10 PM

Change 526754 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.16] Limit Recent Changes disable-table mode to Minerva skin

https://gerrit.wikimedia.org/r/526754

gerritbot added a project: Patch-For-Review.Jul 31 2019, 7:20 PM

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 31 2019, 8:00 PM

Jdlrobson removed a subtask: T228516: Inform AMC users that grouped results are not available on the recent changes page.Jul 31 2019, 8:14 PM

Jdlrobson mentioned this in T228516: Inform AMC users that grouped results are not available on the recent changes page.

Change 526754 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@wmf/1.34.0-wmf.16] Limit Recent Changes disable-table mode to Minerva skin

https://gerrit.wikimedia.org/r/526754

Mentioned in SAL (#wikimedia-operations) [2019-07-31T20:37:16Z] <brennen@deploy1001> Synchronized php-1.34.0-wmf.16/skins/MinervaNeue/includes/MinervaHooks.php: [[gerrit:526754|Limit Recent Changes disable-table mode to Minerva skin]] T228280 (duration: 00m 56s)

No longer blocking train.

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.16; 2019-07-30); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 9:10 PM

Mainframe98 unsubscribed.Aug 1 2019, 6:30 AM

tested on iPhone X, 12.3.1

QA

Environment: beta cluster.

The goal of this task is to ensure that the "grouped" view on the Recent Changes page is not accessible in the Minerva skin. The "grouped view" can be accessed in 3 different ways:

The url parameter -- On the Recent changes page, add enhanced=1 as a url parameter. The presentation of the results should not change.
The advanced filters checkbox (screenshot above). group results by page checkbox does not appear
Enabling a user preference (screenshot also above). -- As a logged in user, enable this user preference. Then on the Recent changes page, the results should still not be grouped.

AC

~~The option to "group results by page" is removed from the Recent changes filters
If a user has the "group changes by page" preference selected, we still show the "old" results on mobile
If the url param enhanced=1 is entered in the RecentChanges page, we still show the "old" results on mobile.

Looks good, moving to signoff

just did an additional review for signoff. Looks good.

Aklapper mentioned this in T253454: Group watchlist entries in mobile view (like in desktop view).May 23 2020, 8:23 PM

Disable grouped results on RecentChanges page on mobile
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Developer notes

QA steps

AC

Details

Related Objects

Event Timeline

QA

AC

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

	F29790877: Screen Shot 2019-07-17 at 15.12.23.png
	Jul 17 2019, 1:52 PM

	F29790869: Screen Shot 2019-07-17 at 15.10.11.png
	Jul 17 2019, 1:52 PM

	F29790900: Screen Shot 2019-07-17 at 15.22.33.png
	Jul 17 2019, 1:52 PM

Disable grouped results on RecentChanges page on mobileClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Developer notes

QA steps

AC

Details

Related Objects

Event Timeline

QA

AC

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Disable grouped results on RecentChanges page on mobile
Closed, ResolvedPublic3 Estimated Story Points
Actions