Page MenuHomePhabricator
Create Task
Maniphest T303194

Gadgets extensions should not cache serialized PHP objects
Closed, ResolvedPublic
Actions

Description

As per T161647: RFC: Deprecate using php serialization inside MediaWiki.

Recent change that motivates this task:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/768274

Details

SubjectRepoBranchLines +/-
tests: Enforce parity between Gadget::serializeDefinition and toArraymediawiki/extensions/Gadgetsmaster+36 -29
Avoid caching serialized PHP objectmediawiki/extensions/Gadgetsmaster+99 -17
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Mar 7 2022, 4:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2022, 4:19 PM
Reedy awarded a token.Mar 7 2022, 4:29 PM
Nikerabbit mentioned this in T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down.Mar 9 2022, 1:35 PM
SD0001 claimed this task.Aug 27 2022, 10:48 AM
gerritbot added a comment.Aug 27 2022, 11:28 AM

Change 826943 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/Gadgets@master] Avoid caching serialized PHP object

https://gerrit.wikimedia.org/r/826943

gerritbot added a project: Patch-For-Review.Aug 27 2022, 11:28 AM
gerritbot added a comment.Jun 22 2023, 6:53 AM

Change 826943 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Avoid caching serialized PHP object

https://gerrit.wikimedia.org/r/826943

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 22 2023, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 22 2023, 7:10 AM
gerritbot added a comment.Sep 20 2023, 9:41 PM

Change 959349 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Gadgets@master] tests: Enforce parity between Gadget::serializeDefinition and toArray

https://gerrit.wikimedia.org/r/959349

gerritbot added a project: Patch-For-Review.Sep 20 2023, 9:41 PM
gerritbot added a comment.Sep 21 2023, 5:37 AM

Change 959349 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] tests: Enforce parity between Gadget::serializeDefinition and toArray

https://gerrit.wikimedia.org/r/959349

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Sep 21 2023, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 21 2023, 6:10 AM
SD0001 closed this task as Resolved.Oct 24 2023, 9:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy