fix: replace logrus with slog #781
Open
+29
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the logging implementation from the third-party logrus library to Go's standard library slog, which was introduced to provide structured logging capabilities natively. The change modernizes the logging approach by using structured logging patterns and removes an external dependency.
- Replaces logrus imports with slog throughout the codebase
- Updates logging calls to use structured logging format with key-value pairs
- Modifies logger initialization to use slog handlers instead of logrus formatters
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Removes logrus dependency from module requirements |
| pkg/log/io.go | Updates IOLogger to use slog.Logger and converts log calls to structured format |
| pkg/log/io_test.go | Migrates test setup from logrus to slog with custom time attribute removal |
| internal/ghmcp/server.go | Replaces logrus with slog for server logging and adds structured log messages |
Comments suppressed due to low confidence (1)
pkg/log/io_test.go:60
- [nitpick] The function name
RemoveTimeAttrshould follow Go naming conventions and be more descriptive. Consider renaming toremoveTimeAttributeorfilterTimeAttributeto better indicate its purpose as a filter function.
func RemoveTimeAttr(groups []string, a slog.Attr) slog.Attr {
Signed-off-by: Bailey Hayes <behayes2@gmail.com>
Signed-off-by: Bailey Hayes <behayes2@gmail.com>
ricochet
force-pushed
the
fix/logrus-to-slog
branch
from
25c669f to
8dab75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang's blog article introducing slog calls out logrus directly as tooling it aims to replace with a solution in the standard language library.
This change replaces logrus with slog and adjusts some of the log outputs to use structured logs.
Closes: #780