Console: Unify console commands with path argument #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, much cleaner now. |
mergify bot
added a commit
that referenced
this pull request
Feb 3, 2025
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.6.0 to 4.7.0. Release notes *Sourced from [actions/setup-java's releases](https://github.com/actions/setup-java/releases).* > v4.7.0 > ------ > > What's Changed > -------------- > > * Configure Dependabot settings by [`@HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-java#722](https://redirect.github.com/actions/setup-java/pull/722) > * README Update: Added a permissions section by [`@benwells`](https://github.com/benwells) in [actions/setup-java#723](https://redirect.github.com/actions/setup-java/pull/723) > * Upgrade `cache` from version 3.2.4 to 4.0.0 by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-java#724](https://redirect.github.com/actions/setup-java/pull/724) > * Upgrade `@actions/http-client` from 2.2.1 to 2.2.3 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#728](https://redirect.github.com/actions/setup-java/pull/728) > * Upgrade `actions/publish-immutable-action` from 0.0.3 to 0.0.4 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#727](https://redirect.github.com/actions/setup-java/pull/727) > * Upgrade `@types/jest` from 29.5.12 to 29.5.14 by [`@dependabot`](https://github.com/dependabot) in [actions/setup-java#729](https://redirect.github.com/actions/setup-java/pull/729) > > New Contributors > ---------------- > > * [`@benwells`](https://github.com/benwells) made their first contribution in [actions/setup-java#723](https://redirect.github.com/actions/setup-java/pull/723) > > **Full Changelog**: <actions/setup-java@v4...v4.7.0> Commits * [`3a4f6e1`](actions/setup-java@3a4f6e1) Bump `@types/jest` from 29.5.12 to 29.5.14 ([#729](https://redirect.github.com/actions/setup-java/issues/729)) * [`25f376e`](actions/setup-java@25f376e) Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 ([#727](https://redirect.github.com/actions/setup-java/issues/727)) * [`d4e4b6b`](actions/setup-java@d4e4b6b) Bump `@actions/http-client` from 2.2.1 to 2.2.3 ([#728](https://redirect.github.com/actions/setup-java/issues/728)) * [`28b532b`](actions/setup-java@28b532b) Create dependabot.yml ([#722](https://redirect.github.com/actions/setup-java/issues/722)) * [`51ab6d2`](actions/setup-java@51ab6d2) Update cache from 3.2.4 to 4.0.0 ([#724](https://redirect.github.com/actions/setup-java/issues/724)) * [`99d3141`](actions/setup-java@99d3141) Update README.md ([#723](https://redirect.github.com/actions/setup-java/issues/723)) * See full diff in [compare view](actions/setup-java@7a6d8a8...3a4f6e1) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes mainly affect the methods:
executeConnectexecuteCreateDatabaseexecuteDropDatabaseand unify the tests for "already connected database", "empty url", and "locked database" by refactoring these tests to private methods called:
checkDatabaseIsConnectedcheckDatabaseIsLockedcheckUrlIsEmptywhere each is throwing a
ConsoleExceptionif triggered.This not only makes the code cleaner and has less duplication, but I think it uncovered a problem with testing (see changes in tests): Some tests seemed to pass because no exception is thrown but just a message was printed.
Furthermore, a helper method preprocessing the local database URL,
parseLocalUrlis added to unify handling of this string.Motivation
The commands above react differently to certain states while they should be similar if not same.
Related issues
#579
#599
Additional Notes
executeListDatabasesclosecommand as it currently disconnects and not closes a database in the sense of the endpoint.checkDatabaseIsOpenfromArcadeDBExceptiontoConsoleExceptionto match others.Checklist
mvn clean packagecommand