Skip to content

OutputFile: copy timing information to wrapped packets #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Nov 24, 2015

Conversation

cchampet pushed a commit to cchampet/avTranscoder that referenced this pull request Nov 6, 2015
@cchampet cchampet force-pushed the fix_timingOfPackets branch from f9e8f77 to 3a973e2 Compare November 17, 2015 15:44
Clement Champetier added 26 commits November 17, 2015 16:47
According to the ffmpeg documentation, if the given packet is reference-
counted, the writting function will take ownership of this reference and
unreference it later when it sees fit. The caller must not access the
data through this reference after this function returns.
The flag can be usefull to have info about the content of the packet:
* AV_PKT_FLAG_KEY: The packet contains a keyframe
* AV_PKT_FLAG_CORRUPT: The packet content is corrupted.
* Cannot copy timing information if there is no case.
* Frame::getAVStream returns a pointer instead of a reference.
…ration

* FFmpeg / libav already log a warning and manage this issue (by
creating new dts/pts/duration for the packet).
* These instructions fix nothing.
* Use private attributes:
    * _lastWrappedPacketDuration: to get duration of generated packets.
    * _wrappedPacketsDuration: to get the correct video stream duration.
* Temporary solution of OutputFile::wrap: copy duration of packet wrapped.
getOutputDuration and getStreamDuration methods return duration as
float.
* We do not rewrap all streams, so the global bit rate is different.
* But we check the bitrate of each stream wrapped.
Set default log level to WARNING for all tests.
@cchampet cchampet changed the title [WIP] OutputFile: copy timing information to wrapped packe OutputFile: copy timing information to wrapped packets Nov 20, 2015
valnoel added a commit that referenced this pull request Nov 24, 2015
OutputFile: copy timing information to wrapped packets
@valnoel valnoel merged commit ac206c9 into avTranscoder:develop Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy