-
Notifications
You must be signed in to change notification settings - Fork 50
OutputFile: copy timing information to wrapped packets #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchampet
pushed a commit
to cchampet/avTranscoder
that referenced
this pull request
Nov 6, 2015
…ffset Manage negative offset
f9e8f77
to
3a973e2
Compare
According to the ffmpeg documentation, if the given packet is reference- counted, the writting function will take ownership of this reference and unreference it later when it sees fit. The caller must not access the data through this reference after this function returns.
The flag can be usefull to have info about the content of the packet: * AV_PKT_FLAG_KEY: The packet contains a keyframe * AV_PKT_FLAG_CORRUPT: The packet content is corrupted.
* Cannot copy timing information if there is no case. * Frame::getAVStream returns a pointer instead of a reference.
…into fix_timingOfPackets
…ration * FFmpeg / libav already log a warning and manage this issue (by creating new dts/pts/duration for the packet). * These instructions fix nothing.
* Use private attributes: * _lastWrappedPacketDuration: to get duration of generated packets. * _wrappedPacketsDuration: to get the correct video stream duration. * Temporary solution of OutputFile::wrap: copy duration of packet wrapped.
getOutputDuration and getStreamDuration methods return duration as float.
* We do not rewrap all streams, so the global bit rate is different. * But we check the bitrate of each stream wrapped.
…n testTranscoderRewrap See issue avTranscoder#173
Set default log level to WARNING for all tests.
If some data has already been wrapped in the stream.
The assert checks the duration of the stream to the duration of the output expected.
* All audio packets have not the same size. * Need to compute it at each time. * See the ffmpeg way: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/mux.c#L521 https://github.com/FFmpeg/FFmpeg/blob/7bf465abf3697dcddfb4021e6db9aeec1724f7ed/libavformat/utils.c#L769
The output audio stream has not the correct number of samples.
Because they may be NULL.
The generator hs to be allocated!
The macro to log (LOG_WARN...) already instanciate a 'std::stringstream os'.
valnoel
added a commit
that referenced
this pull request
Nov 24, 2015
OutputFile: copy timing information to wrapped packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ffmpeg.org/doxygen/2.8/group__lavf__decoding.html#ga4fdb3084415a82e3810de6ee60e46a61
https://ffmpeg.org/doxygen/2.8/group__lavf__encoding.html#ga37352ed2c63493c38219d935e71db6c1