Skip to content

fix: show correct min and max values in validation errors #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

fix: show correct min and max values in validation errors #122

merged 1 commit into from
May 30, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 30, 2023

Related: coder/coder#7582

This PR fixes the invalid validation error message, show ptr instead of the value.

@mtojek mtojek self-assigned this May 30, 2023
@mtojek mtojek marked this pull request as ready for review May 30, 2023 11:54
@mtojek mtojek requested a review from mafredri May 30, 2023 11:54
@mtojek mtojek merged commit 2f64d4c into coder:main May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtojek @mafredri
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy