pre-commit: Add pre-commit-hooks and auto-walrus #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e50442e to
9284537
Compare
|
Looks good, but I'll only rebase this and merge after I finish the member initializer list namespace indentation fix, which includes some small refactoring to the nesting state update function that would probably conflict with this. |
|
Hey cclauss, could you review #353 first? Like I said, I think these two PRs might conflict and I'd prefer to merge the vital fix first. |
44eb765 to
310fbe8
Compare
|
This pull request will not conflict with #353. |
aaronliu0130
approved these changes
Apr 1, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pre-commit/pre-commit-hooks
https://github.com/MarcoGorelli/auto-walrus
The three TODOs can be done in follow-on pull requests.