Skip to content

pre-commit: Add pre-commit-hooks and auto-walrus #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Mar 22, 2025

@cclauss cclauss force-pushed the more-pre-commit branch 7 times, most recently from e50442e to 9284537 Compare March 22, 2025 23:24
@cclauss cclauss added the tests label Mar 23, 2025
@cclauss cclauss requested a review from aaronliu0130 March 23, 2025 13:08
@aaronliu0130
Copy link
Member

Looks good, but I'll only rebase this and merge after I finish the member initializer list namespace indentation fix, which includes some small refactoring to the nesting state update function that would probably conflict with this.

@aaronliu0130
Copy link
Member

Hey cclauss, could you review #353 first? Like I said, I think these two PRs might conflict and I'd prefer to merge the vital fix first.

@cclauss cclauss force-pushed the more-pre-commit branch 2 times, most recently from 44eb765 to 310fbe8 Compare April 1, 2025 19:18
@cclauss cclauss requested a review from jayvdb April 1, 2025 19:41
@cclauss
Copy link
Member Author

cclauss commented Apr 1, 2025

This pull request will not conflict with #353.

Copy link
Member

@aaronliu0130 aaronliu0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, I'd think that one would auto-walrus access_match.

Either way, hopefully we can review fixing the high-priority namespace indentation false positives soon.

@cclauss
Copy link
Member Author

cclauss commented Apr 2, 2025

access_match might be a long lines issue.
https://github.com/MarcoGorelli/auto-walrus?tab=readme-ov-file#configuration

@cclauss cclauss merged commit d520020 into develop Apr 2, 2025
11 checks passed
@cclauss cclauss deleted the more-pre-commit branch April 2, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy