-
Notifications
You must be signed in to change notification settings - Fork 295
fix(indentation_namespace): false positive for MemInitLists #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0b18614
to
e642f74
Compare
changelog for this force push
|
changelog for this force push
Previous actions run (success): https://github.com/cpplint/cpplint/actions/runs/14022517156?pr=353 |
e642f74
to
3034ee0
Compare
In our code base it solves the issues with members initializers, but there is one issue remaining:
cpplint complains about the last line. |
I don't think we would bother with that, unfortunately... catching that would probably make cpplint way slower and the usual linesplitting AFAIK is to split inside the parentheses like static constexpr auto types = hana::make_tuple(BOOST_PP_SEQ_ENUM(
BOOST_PP_SEQ_TRANSFORM(EXPAND_TO_HANA_TYPE, _, data_types_macro))); which is also what clang-format with Google style gives you. |
Okay, we'll just NOLINT this line then. Thanks for the quick fix with this PR! |
cf68b33
to
6566e2d
Compare
force-push changelog
|
@cclauss Please review. |
samples/boost-sample/exclude.def
Outdated
@@ -19,7 +19,6 @@ src/inspect/unnamed_namespace_check.hpp:28: Do not indent within a namespace. | |||
src/inspect/unnamed_namespace_check.hpp:28: { should almost always be at the end of the previous line [whitespace/braces] [4] | |||
src/inspect/unnamed_namespace_check.hpp:29: Do not indent within a namespace. [whitespace/indent_namespace] [4] | |||
src/inspect/unnamed_namespace_check.hpp:29: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] | |||
src/inspect/unnamed_namespace_check.hpp:30: Do not indent within a namespace. [whitespace/indent_namespace] [4] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a false negative, but it's due to the already-violation that is whitespace/braces so I don't think it's worth the extra compute tradeoff to support.
6566e2d
to
73a57b5
Compare
Rebase includes typo fix. Pls review |
This has now been sitting here for 2 weeks. I can rebase after #334 is merged to add a new changelog section. |
Please resolve the git conflict in |
Great! Thanks. However rebasing is blocked by #334, which would bump the version and add a new block in the changelog. |
#334 is now merged. Updating the version should only be done in the release process, not before. Modifying At release time, we can update the version and remove the blank lines.
When releasing, we will:
![]() |
In my opinion, it is worse. It can falsely confuse users (and support agents) into thinking the trunk software is on the latest stable release, and the only "benefit" of only updating the version on release is not needing to debate the version number. Nearly every major project I know bumps the version number immediately after release. I also do not see different PRs making different guesses on the version number, and it bumps the semver feature part as I feel like we should have at least e.g. #64 in the next release. Maybe we should just put a temporary version number (e.g. 2.0.1-next for right after releasing 2.0.1) in cpplint.py and leave the new CHANGELOG header as "TBA"? I like your blank lines idea, though. |
Split out parentheses counting namespace consumption to have enough available conditional branches for next commit Add type hints # Conflicts: # cpplint.py
Fix whitespace/indentation_namespace false positive for member initializer lists (MemInitLists) Adds new _ConstructorInfo, _WrappedInfo, and _MemInitListInfo nesting stack element classes Remember last-popped nesting stack item Update descriptor.pb.cc to 2016-12-16 version (commit 183d31c)
73a57b5
to
5ae674c
Compare
https://github.com/pydantic/pydantic/blob/04fd6395c7165232785992a6ad0e817e9db6e590/pydantic/version.py#L9 Same as the recent release made four days ago. Preparing for tomorrow’s release of Celery celery/celery#9660 |
Should fix #346
A massive commit for a seemingly simple problem!
Fix whitespace/indentation_namespace false positive for member initializer lists (MemInitLists)
Adds new _ConstructorInfo, _WrappedInfo, and _MemInitListInfo nesting stack element classes
Remember last-popped nesting stack item
Update descriptor.pb.cc to 2016-12-16 version (commit 183d31c)
chore: refactor part of NestingState.Update()
Split out parentheses counting namespace consumption to have enough available conditional branches for next commit
Add type hints