Skip to content

build: fix ffmpeg generation on Windows non-x64 #47768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: fix ffmpeg generation on Windows non-x64 #47768

wants to merge 1 commit into from
+6 −0

Conversation

codebytere
Copy link
Member

Description of Change

Closes #47766
Refs #45466

Fixes an issue where ffmpeg builds didn't get built correctly on Windows arm64 or ia32

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/x64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/arm64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/ia32ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

It seems we didn't properly set GN_EXTRA_ARGS for those platforms - i went back and checked our old appveyor configs and it's there:

Screenshot 2025-07-16 at 10 40 00 AM

so we need to add that back here.

Checklist

Release Notes

Notes: none.

@codebytere codebytere requested a review from jkleinsc July 16, 2025 08:40
@codebytere codebytere requested a review from a team as a code owner July 16, 2025 08:40
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ffmpeg-v36.1.0-win32-ia32.zip" contains 64-bit DLL instead of 32-bit — breaks 32-bit builds
2 participants
@codebytere @VerteDinde
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy