Skip to content

build: fix ffmpeg generation on Windows non-x64 #47768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

build: fix ffmpeg generation on Windows non-x64 #47768

merged 2 commits into from
Jul 21, 2025
+7 −1

Conversation

codebytere
Copy link
Member

Description of Change

Closes #47766
Refs #45466

Fixes an issue where ffmpeg builds didn't get built correctly on Windows arm64 or ia32

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/x64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/arm64ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

src on git:7a73d3ec5a6e8 ❯ file ~/Downloads/ia32ffmpeg.dll                    10:25AM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) x86-64, for MS Windows

It seems we didn't properly set GN_EXTRA_ARGS for those platforms - i went back and checked our old appveyor configs and it's there:

Screenshot 2025-07-16 at 10 40 00 AM

so we need to add that back here.

Checklist

Release Notes

Notes: none.

@codebytere codebytere requested a review from jkleinsc July 16, 2025 08:40
@codebytere codebytere requested a review from a team as a code owner July 16, 2025 08:40
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 16, 2025
jkleinsc
jkleinsc requested changes Jul 18, 2025
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good; just need to put back the conditional to only run this on release.

@codebytere
Copy link
Member Author

codebytere commented Jul 21, 2025 •
edited
Loading

@jkleinsc yes, i did that intentionally to test the fix and would have replaced it before merging - confirmed:

src on git:517f2e01e681d ❯ file ~/Downloads/arm64ffmpeg.dll                    12:10PM
/Users/codebytere/Downloads/ffmpeg.dll: PE32+ executable (DLL) (console) Aarch64, for MS Windows

@codebytere codebytere requested a review from jkleinsc July 21, 2025 10:11
@jkleinsc jkleinsc merged commit cf871bc into main Jul 21, 2025
104 of 105 checks passed
@jkleinsc jkleinsc deleted the fix-ffmpeg branch July 21, 2025 15:33
@release-clerk
Copy link

release-clerk bot commented Jul 21, 2025

No Release Notes

This was referenced Jul 21, 2025
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 21, 2025

I have automatically backported this PR to "38-x-y", please check out #47844

@trop
Copy link
Contributor

trop bot commented Jul 21, 2025

I have automatically backported this PR to "35-x-y", please check out #47845

@trop trop bot removed the target/38-x-y PR should also be added to the "38-x-y" branch. label Jul 21, 2025
@trop
Copy link
Contributor

trop bot commented Jul 21, 2025

I have automatically backported this PR to "37-x-y", please check out #47846

@trop
Copy link
Contributor

trop bot commented Jul 21, 2025

I have automatically backported this PR to "36-x-y", please check out #47847

@trop trop bot added in-flight/36-x-y merged/38-x-y PR was merged to the "38-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. and removed target/35-x-y PR should also be added to the "35-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. in-flight/38-x-y in-flight/37-x-y in-flight/35-x-y in-flight/36-x-y labels Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ffmpeg-v36.1.0-win32-ia32.zip" contains 64-bit DLL instead of 32-bit — breaks 32-bit builds
3 participants
@codebytere @jkleinsc @VerteDinde
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy