Improvements for images (correct reading/writing possitions) #702

Siemienik · 2018-12-01T11:50:25Z

Improvements for image`s positioning/stretching and their properly writing to xlsx and readign from xlsx with fully backward compatibility.

Before that changes,

Reading images positions works wrong. This example show it very well,
original file looks that:

after i open this file and save without any changes:

Backward compability

My solution was designed to handle current col/row and calculate it to nativeCol, nativeColOff, nativeRow, nativeRowOff. A lot of tests was written to ensure properly working with dependents apps .

I will be glad for quick checking/approval this pull request, I am open for your comments and ready to make some fixes.

issues

#650
#467

…g from xlsx with fully back compatible. NEW Anchor model NEW Integration tests test for image`s reader & writer NEW Unit tests for Anchor

Siemienik · 2019-01-10T01:37:18Z

~~Hi everyone, I didn't note any maintainer's activity, so as long as it's required I am going to maintain this wonderful open source library in my fork: https://github.com/p3rio/exceljs~~

I hope that, in the future both repositories become to be merged ;)

alubbe

I don't really know enough about images in excel, but I like the tests, so I think this can be merged. Should we maybe do a rebase?

alubbe · 2019-01-15T11:14:47Z

lib/doc/worksheet.js

@@ -620,5 +631,13 @@ Worksheet.prototype = {
    this.views = value.views;
    this.autoFilter = value.autoFilter;
    this._media = value.media;
+
+    var self = this;


I think this line is not needed

alubbe · 2019-01-15T11:15:39Z

lib/doc/anchor.js

@@ -0,0 +1,56 @@
+/**
+ * Copyright (c) 2018 Paweł Siemienik


Personally, I think this shouldn't be in individual files

@alubbe In each file is copyright/author block similar to this, if it's wrong could you write how it should looks like?

ah indeed - I had completely missed that. Let's leave that in then.

@guyonroche I've only seen licenses repeated in every file if you want to charge license fees for your IP, but since we use MIT I think there's no need to have this repeated everywhere - it's just noise that needs maintenance. Would you be okay with removing them everywhere?

@alubbe Yeah - We could probably get away with just the LICENCE file with links from the README.md and main excel.js file.
I finally have more spare time now so I can start working through the PRs. I'll test this one tomorrow morning

Siemienik · 2019-01-15T20:21:06Z

Thank You @alubbe for review, I will make required fixes as soon as possible ;)

alubbe · 2019-01-21T09:53:10Z

Happy now with this PR code-wise, but I can't speak to the functionality. Can anyone test it with an actual excel file?

Siemienik · 2019-01-21T11:08:31Z

I had to made this fixes for my businesses project when I read and modify xlsx files. With this PL it works fine.

below is link to xlsx file, what i prepared for test purposes. If you have possible, just download, open&write it (exceljs v1.7.0):
https://github.com/exceljs/exceljs/blob/c8e2ce5190a3b627a33c90a7fee1358351443440/spec/integration/data/images.xlsx

moddaman · 2019-01-28T11:33:24Z

nice @Siemienik

Looking to forward to this being merged. Until then i have updated my package.json to use `"exceljs": "github:p3rio/exceljs#build"``.

How do i use this functionality? Do I use it the same way?
In your commits I can see som use of the Anchor class?

Could you update the readme?

kaidoj · 2019-02-13T19:02:52Z

This did not work for me. I tested my excel in 3 different Excel readers and it only worked in one. Images where placed wrong. For now i went back to my fork. That atleast works with my offsets set.

tl: {
                        col: imageColumnPosition + 0.05,
                        row: i + 0.05,
                    },
                    br: {
                        col: imageColumnPosition + 0.95,
                        row: i + 0.95 //this aint working either. I have to use 1 but that is bad. Image overlapping row line.
}

Siemienik · 2019-02-18T21:51:36Z

@kaidoj could You share excel files which were failed?

Siemienik · 2019-02-18T21:56:38Z

@moddaman it enough to use images like before. This PR fixes counting possitions for images in reader and writer. Before that, reader and writer ignore current column width and always use the same value, so when column width was larger than 'this const' it put image to another column.

alubbe · 2019-03-12T12:37:13Z

@kaidoj could you please share a file where it doesn't work?
@Siemienik why are the tests red - is our test runner broken? :D

dogusev · 2019-03-29T13:44:10Z

@alubbe
Any chance to have it merged?

alubbe · 2019-03-31T09:38:08Z

@alubbe Yeah - We could probably get away with just the LICENCE file with links from the README.md and main excel.js file.
I finally have more spare time now so I can start working through the PRs. I'll test this one tomorrow morning

@guyonroche awesome, will be great to have you back! :)

mjiskinng · 2021-07-24T05:24:12Z

Hi Guyz how to solve this issue. Any idea if i add dependencies "exceljs": "github:p3rio/exceljs#build" it still throws error i believe its clashing with the latest exceljs. Any idea how can i work with both in parallel using image functionality of p3rio and rest from master. Please help me this issue is now taking more than 1 month..

Siemienik · 2021-07-26T13:35:02Z

Hi Guyz how to solve this issue. Any idea if i add dependencies "exceljs": "github:p3rio/exceljs#build" it still throws error i believe its clashing with the latest exceljs. Any idea how can i work with both in parallel using image functionality of p3rio and rest from master. Please help me this issue is now taking more than 1 month..

@mjiskinng Since 1 Apr 2019 this PR is included in the ExcelJS main package. Could you use :
"exceljs":"^4.2.1" ?

Improvements for images and their properly writing to xlsx and readin…

915d91d

…g from xlsx with fully back compatible. NEW Anchor model NEW Integration tests test for image`s reader & writer NEW Unit tests for Anchor

Siemienik changed the title ~~Improvements for images (correct reading/writing stream)~~ Improvements for images (correct reading/writing possitions) Dec 1, 2018

This was referenced Dec 1, 2018

Image location don't respect Column width #650

Open

Image position - stretching image #467

Closed

Image positioning fix #691

Closed

Editing existing excel file not read & write #704

Open

Siemienik mentioned this pull request Jan 10, 2019

Project still maintained / looking for maintainers? #720

Closed

Siemienik force-pushed the master branch from 9c914d2 to 915d91d Compare January 10, 2019 21:31

Siemienik requested review from guyonroche, alubbe and defshift January 14, 2019 15:36

Merge branch 'master' of github.com:exceljs/exceljs

7946791

alubbe reviewed Jan 15, 2019

View reviewed changes

fix

c8e2ce5

Siemienik mentioned this pull request Jan 20, 2019

Reading / writing .xlsx file with picture changes picture's scale #344

Open

Siemienik mentioned this pull request Jan 24, 2019

Worksheet with form controls #392

Open

karlvr mentioned this pull request Feb 14, 2019

Add support for adding images anchored to one cell #746

Merged

Siemienik mentioned this pull request Feb 18, 2019

Keep original image dimensions #738

Open

Merge branch 'master' into master

4613acc

guyonroche merged commit 4613acc into exceljs:master Apr 1, 2019

Siemienik mentioned this pull request May 26, 2020

[BUG] File won't be saved properly (read&write) #1286

Open

Improvements for images (correct reading/writing possitions) #702

Improvements for images (correct reading/writing possitions) #702

Uh oh!

Conversation

Siemienik commented Dec 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before that changes,

Backward compability

issues

Uh oh!

Siemienik commented Jan 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alubbe left a comment

Choose a reason for hiding this comment

Uh oh!

alubbe Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

alubbe Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

Siemienik Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alubbe Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

guyonroche Mar 29, 2019

Choose a reason for hiding this comment

Uh oh!

Siemienik commented Jan 15, 2019

Uh oh!

alubbe commented Jan 21, 2019

Uh oh!

Siemienik commented Jan 21, 2019

Uh oh!

moddaman commented Jan 28, 2019

Uh oh!

kaidoj commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siemienik commented Feb 18, 2019

Uh oh!

Siemienik commented Feb 18, 2019

Uh oh!

alubbe commented Mar 12, 2019

Uh oh!

dogusev commented Mar 29, 2019

Uh oh!

alubbe commented Mar 31, 2019

Uh oh!

mjiskinng commented Jul 24, 2021

Uh oh!

Siemienik commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Siemienik commented Dec 1, 2018 •

edited

Loading

Siemienik commented Jan 10, 2019 •

edited

Loading

Siemienik Jan 15, 2019 •

edited

Loading

kaidoj commented Feb 13, 2019 •

edited

Loading

Siemienik commented Jul 26, 2021 •

edited

Loading