Only start mixer when audio and video both tracks are added #1851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade so/dll. * fix: use the correct transceiver id. * fix: Support restart camera for win/linux.
…1327) * feat: add way to enable speaker but prefer bluetooth * chore: fix audio override ios
* Don't convert list type to vector, set vector as param. * Fix the crash issue when use video room.
…to avoid blocking of flutter method call.
* replaced logic fetching 'infoDictionary' value * better fallback in the event the RTCScreenSharingExtension key doesn't exist * added a log in case the screen sharing extention id is not found
* Add maxIPv6Networks configuration * Added maxIPv6Networks configuration for darwin * Added max_ipv6_networks configuration for cpp
* feat: add getBufferedAmount for DataChannel. * update. * update. * fix. * update binary for linux.
sometimes video callbacks (onResize, onCanPlay) come before element is findable in DOM. This PR adds the created element as fallback fixes flutter-webrtc#1804
* Media recorder support for iOS/OSX * fix ios and android implementation * update pubspec to point to correct branch * update example * fix formatter * fix macos implementation * fix build on web * review changes --------- Co-authored-by: Dima Rostopira <rostopiradv@gmail.com> Co-authored-by: CloudWebRTC <duanweiwei1982@gmail.com>
* fix: add task runner for linux. * update.
…-webrtc#1752) Co-authored-by: CloudWebRTC <duanweiwei1982@gmail.com>
…#1810)" (flutter-webrtc#1822) This reverts commit 04ccd08.
) * Revert "Revert "Media Recorder implementation Android and iOS (flutter-webrtc#1810)" (flutter-webrtc#1822)" This reverts commit 42eac74. * bump version for dart-webrtc and interface. * update.
|
@cloudwebrtc @suhoge kindly review this. |
Merged
4ea8675 to
8c887d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code started the muxer as soon as either the audio or video track was added, which could cause the app to crash. The updated logic ensures that the muxer only starts after both the audio and video tracks have been added.