fixed(markdown): render the markdown in browser. #505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this repository died? I found this bug today. |
j-rewerts
reviewed
Apr 5, 2019
| @@ -32,7 +32,7 @@ class Markdown extends Requestable { | |||
| * @return {Promise} - the promise for the http request | |||
| */ | |||
| render(options, cb) { | |||
| return this._request('POST', '/markdown', options, cb); | |||
| return this._request('POST', '/markdown', options, cb, true); | |||
There was a problem hiding this comment.
I'm trying to figure out why sending the request as raw rather than JSON would work in the browser. Give me a bit to sort this out.
j-rewerts
added a commit
to j-rewerts/github
that referenced
this pull request
Apr 7, 2019
Fixed github-tools#451. Got the code from PR github-tools#505.
Merged
|
I've created a PR that contains the previous code, as well as a test that verifies this is an issue. |
|
This can be closed @clayreimann. |
|
Closing in favor of #548 |
j-rewerts
added a commit
to j-rewerts/github
that referenced
this pull request
Apr 10, 2019
Fixed github-tools#451. Got the code from PR github-tools#505.
clayreimann
pushed a commit
that referenced
this pull request
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #451
closes #451