-
Notifications
You must be signed in to change notification settings - Fork 56
French translation 🇫🇷 #43
Conversation
@githubtraining/learning-engineering I have made couple edits on 🇬🇧 pages whenever I spotted a typo. |
Thank you so much, @helaili! This is so exciting. ✨ @SophieLegrand, once you proofread, let us know here. Then, I'll merge this into a branch on this upstream repository so we can test, and then we can merge into master. 🎉 cc @githubtraining/programs @githubtraining/learning-engineering @crichID @BonnieC to see awesome translation work 👀 cc @JasonEtco @githubtraining/learning-engineering - I recall asking this before but I don't remember following up, so I apologize. Is it expected behavior that pull requests from forks do not generate drafts? Can we trigger that manually as org owners so that we can test this without an additional merge step to another upstream branch? |
Unfortunately yes 😞 Not an impossible feat for us to support this, but a non-trivial task that we'll have to do.
No - I'll have a think about how we can "deploy" this manually, but none come to mind right away 🤔 A non-great approach, we can pull in the fork as a course on staging (or in production if we'd like) and do some click testing there. |
@helaili I recreated your work over at #44. You can collaborate on it with @SophieLegrand there, and see new changes deployed by clicking on "View deployment". Feel free to close this PR and resume the work there when ready. |
👋 @helaili - This is proof-read on my side, I added my suggestions |
Closing this PR as the code has been moved to a branch and recreated in #44 |
It's kind of explicit with the title ☝️