Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

French translation 🇫🇷 #43

Closed
wants to merge 7 commits into from

Conversation

helaili
Copy link
Contributor

@helaili helaili commented Mar 26, 2020

It's kind of explicit with the title ☝️

@github-learning-lab github-learning-lab bot had a problem deploying to production March 26, 2020 15:41 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production March 27, 2020 10:19 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production March 27, 2020 10:20 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production March 27, 2020 19:50 Failure
@github-learning-lab github-learning-lab bot had a problem deploying to production March 30, 2020 07:54 Failure
@helaili helaili marked this pull request as ready for review March 30, 2020 07:56
@helaili
Copy link
Contributor Author

helaili commented Mar 30, 2020

@githubtraining/learning-engineering I have made couple edits on 🇬🇧 pages whenever I spotted a typo.
For the 🇫🇷 version, @SophieLegrand will gladly proof read

@brianamarie
Copy link
Contributor

Thank you so much, @helaili! This is so exciting. ✨

@SophieLegrand, once you proofread, let us know here. Then, I'll merge this into a branch on this upstream repository so we can test, and then we can merge into master. 🎉

cc @githubtraining/programs @githubtraining/learning-engineering @crichID @BonnieC to see awesome translation work 👀

cc @JasonEtco @githubtraining/learning-engineering - I recall asking this before but I don't remember following up, so I apologize. Is it expected behavior that pull requests from forks do not generate drafts? Can we trigger that manually as org owners so that we can test this without an additional merge step to another upstream branch?

@JasonEtco
Copy link
Contributor

Is it expected behavior that pull requests from forks do not generate drafts?

Unfortunately yes 😞 Not an impossible feat for us to support this, but a non-trivial task that we'll have to do.

Can we trigger that manually as org owners so that we can test this without an additional merge step to another upstream branch?

No - I'll have a think about how we can "deploy" this manually, but none come to mind right away 🤔 A non-great approach, we can pull in the fork as a course on staging (or in production if we'd like) and do some click testing there.

@hectorsector
Copy link
Member

@helaili I recreated your work over at #44. You can collaborate on it with @SophieLegrand there, and see new changes deployed by clicking on "View deployment". Feel free to close this PR and resume the work there when ready.

@SophieLegrand
Copy link

👋 @helaili - This is proof-read on my side, I added my suggestions

@lmkeston
Copy link
Contributor

Closing this PR as the code has been moved to a branch and recreated in #44

@lmkeston lmkeston closed this Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy