Support relative paths in PlainInit/PlainClone. fixes #1610 #1611
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbgf
requested changes
Jul 24, 2025
There was a problem hiding this comment.
@glycerine thank you for submitting this PR.
To catch potential regressions in the future, please also amend the TestPlainClone test in repository_test.go to something like:
func (s *RepositorySuite) TestPlainClone() {
dir := "rel-dir"
err := os.Mkdir(dir, 0o755)
s.Require().NoError(err)
defer func() {
os.RemoveAll(dir)
}()
...| @@ -295,6 +295,17 @@ func PlainInit(path string, isBare bool, options ...InitOption) (*Repository, er | |||
| return Init(s, options...) | |||
| } | |||
| } else { | |||
| // Allow users to use relative paths. Convert them | |||
There was a problem hiding this comment.
This is only handling the non bare clones. Please move the logic above the if isBare {.
Instead of the comment, we could just add a // go-git/go-git#1610
|
@pjbgf Hi Paulo, feel free to redo this however you like; I don't need any credit--and I don't have time to do any more on it at the moment. So take it, and run with it. Adding tests is a good idea, but as I say, I won't get to it; and I would likely make mistakes in doing so since I'm not familiar with the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest fix for #1610, as it emulates what
is mostly tested in the test suite: absolute paths
generated by os.MkdirTemp.
We simply convert relative paths to absolute path and proceed.
Fixes #1610