JSON decode response for alarms endpoint #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgenhaas
added a commit
to jurgenhaas/core
that referenced
this pull request
Jun 16, 2020
20 tasks
fabaff
approved these changes
Jun 16, 2020
MartinHjelmare
pushed a commit
to home-assistant/core
that referenced
this pull request
Jul 5, 2020
* Add NetdataAlarms alarm sensor to additionally collect alarm information from the netdata host * Incorporate suggested changes by @MartinHjelmare * Change from pictures to icons * Simplify API callbacks following home-assistant-ecosystem/python-netdata/pull/5 and home-assistant-ecosystem/python-netdata/pull/6 * Bring back lost empty line * Update the library version in manifest.json * Update the library version in requirements_all.txt * Linting * Linting * Fix typo * Do not count cleared and undefined alarms as warnings * Do not count cleared, undefined and uninitialized alarms as warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes /issues/4