case-insensitive check for BIC #1547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok. Furthermore, the IBAN-validation also is case-insensitive.
|
For consistency with IBAN I agree. I think we should add in the comments of both validations that the validation is handled in a case-insensitive manner and that it is up to the user to normalize the input (e.g. convert everything into uppercase before persisting the user input). |
|
Sounds good to me. Will you need an amended pull request/patch? |
|
please add the requested change to this PR. |
|
OK, comments are amended. |
|
Thanks, your changes look good to me. |
|
@netzkind could your squash those commits? |
|
@netzkind please squash your commits and prefix the commit message with I will merge after this small changes. |
|
@netzkind are you willing to apply the above mentioned changes? |
Arkni
pushed a commit
to Arkni/jquery-validation
that referenced
this pull request
Nov 5, 2015
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok. Furthermore, the IBAN-validation also is case-insensitive. Closes jquery-validation#1547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok.
Furthermore, the IBAN-validation also is case-insensitive.