Aditional: case-insensitive check for BIC #1636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found no appearant reason why a BIC has to be all-upper, so allowing customers to enter it lowercase or mixed should be ok. Furthermore, the IBAN-validation also is case-insensitive. Closes jquery-validation#1547
|
@Arkni would you mind adding a unit test? |
|
will do when time allows. |
|
@staabm |
|
thx. next step for me is learning "how to merge it right" ;) |
Yep 😁 |
Good :D
Yes, it helps avoiding closing issues and PR manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed and rebased #1547.
The authorship still maintained. So you can close #1547 in favor of this one