Adding support to external MariaDB server #1311

wfelipew · 2025-06-30T16:42:05Z

Adding support to external MariaDB server as requested on #199.

It supports:

Connections
Users
Grants
Databases
Backups
SQLJobs

mmontes11 · 2025-07-01T08:32:20Z

Thanks for raising this @wfelipew . Will take a closer look in the following weeks and let you know. Do you mind rebasing with main?

mmontes11 · 2025-07-16T15:57:11Z

Hey @wfelipew ! As we get close to the 25.08 release, I'm finally finding some time to review this. Would you mind resolving the conflicts and rebasing?

wfelipew · 2025-07-16T20:13:03Z

Hey @wfelipew ! As we get close to the 25.08 release, I'm finally finding some time to review this. Would you mind resolving the conflicts and rebasing?

done

mmontes11 · 2025-07-16T20:35:19Z

Thanks for the effort @wfelipew ! Looks promising, will take a look tomorrow.

mmontes11

Thank you very much for taking the initiative, I do appreciate the effort made here 🙏🏻

Whilst I believe you are on the right track, I think some adaptations are needed, specially around the new abstractions that we have created. Please see my comments, let me know what you think.

mmontes11 · 2025-07-17T16:32:02Z

api/v1alpha1/mariadb_types.go

+// +kubebuilder:printcolumn:name="Primary",type="string",JSONPath=".status.currentPrimary"
+// +kubebuilder:printcolumn:name="Updates",type="string",JSONPath=".spec.updateStrategy.type"


These two annotations can be omitted for ExternalMariaDB: We don't know what the primary is nor we are handling updates.

mmontes11 · 2025-07-17T16:33:18Z

api/v1alpha1/mariadb_types.go

+	pp := corev1.PullIfNotPresent
+	return pp


Suggested change

pp := corev1.PullIfNotPresent

return pp

return corev1.PullIfNotPresent

We are returning a copy, it is safe to return corev1.PullIfNotPresent directly unless I am missing something

mmontes11 · 2025-07-17T16:34:47Z

api/v1alpha1/mariadb_types.go

+
+// Get image pull secrets
+func (m *ExternalMariaDB) GetImagePullSecrets() []LocalObjectReference {
+	return nil


Suggested change

return nil

return nil // ExternalMariaDB uses official MariaDB images (publicly available) for the Backups

mmontes11 · 2025-07-17T16:35:03Z

api/v1alpha1/mariadb_types.go

+
+// Get image
+func (m *ExternalMariaDB) GetImage() string {
+	return fmt.Sprintf("mariadb:%s", m.Status.Version)


Suggested change

return fmt.Sprintf("mariadb:%s", m.Status.Version)

return fmt.Sprintf("mariadb:%s", m.Status.Version) // // ExternalMariaDB uses official MariaDB images (publicly available) for the Backups

mmontes11 · 2025-07-17T16:38:58Z

api/v1alpha1/mariadb_types.go

+	// if !m.IsTLSEnabled() {
+	// 	return false
+	// }
+	// tls := ptr.Deref(m.Spec.TLS, TLS{})
+	// return ptr.Deref(tls.Required, false)
+	return false


Suggested change

// if !m.IsTLSEnabled() {

// return false

// }

// tls := ptr.Deref(m.Spec.TLS, TLS{})

// return ptr.Deref(tls.Required, false)

return false

return false // ExternalMariaDB does not make use of this, as it is a internal server setting

mmontes11 · 2025-07-17T20:10:01Z

pkg/builder/connection_builder.go

+			ObjectReference: mariadbv1alpha1.ObjectReference{
+				Name: opts.ExternalMariaDB.Name,
+			},
+			Kind:      "ExternalMariaDB",


Could we create a constant for this along with the other kinds?

mariadb-operator/api/v1alpha1/groupversion_info.go

Line 15 in 3da8aa4

PhysicalBackupKind = "PhysicalBackup"

mmontes11 · 2025-07-17T20:12:20Z

pkg/builder/connection_builder.go

@@ -49,6 +60,15 @@ func (b *Builder) BuildConnection(opts ConnectionOpts, owner metav1.Object) (*ma
 	if opts.Template != nil {
 		conn.Spec.ConnectionTemplate = *opts.Template
 	}
+
+	if b == nil {


In which case gets b to be nil, if using the NewBuilder?

mariadb-operator/pkg/builder/builder.go

Line 15 in 3da8aa4

func NewBuilder(scheme *runtime.Scheme, env *environment.OperatorEnv, discovery *discovery.Discovery) *Builder {

mmontes11 · 2025-07-17T20:16:02Z

pkg/command/backup.go

@@ -34,6 +35,11 @@ type BackupOpts struct {
 	ExtraOpts            []string
 }

+type ConnectionParamsAwareInterface interface {


Isn't this defined under pkg/interfaces already?

mmontes11 · 2025-07-17T20:17:11Z

pkg/command/command.go

-	}
-	return statefulset.ServiceFQDN(mariadb.ObjectMeta)
-}
+// func host(mariadb interfaces.MariaDBGenericInterface) string {


I think this is equivalent to GetHost, probably we can remove

mmontes11 · 2025-07-17T20:18:23Z

pkg/interfaces/interfaces.go

+	TLSServerCertSecretKey() types.NamespacedName
+}
+
+type ReplicationAwareInterface interface {


I think this interface can be removed, please see my previous comments

wfelipew · 2025-07-18T15:33:21Z

Thank you very much for taking the initiative, I do appreciate the effort made here 🙏🏻

Whilst I believe you are on the right track, I think some adaptations are needed, specially around the new abstractions that we have created. Please see my comments, let me know what you think.

Thanks for the review, I'll working on it today

wfelipew · 2025-07-18T20:06:42Z

@mmontes11 I believe I fixed everything except by this one -> #1311 (comment)

wfelipew mentioned this pull request Jun 30, 2025

[Feature] Manage existing Database #199

Open

wfelipew force-pushed the external-mariadb branch from 9fa7ae3 to bd01bda Compare July 1, 2025 09:43

wfelipew force-pushed the external-mariadb branch 6 times, most recently from 4085384 to 59e9091 Compare July 16, 2025 19:47

mmontes11 self-assigned this Jul 16, 2025

mmontes11 self-requested a review July 17, 2025 15:46

mmontes11 force-pushed the external-mariadb branch from 59e9091 to 6805491 Compare July 17, 2025 15:48

mmontes11 requested changes Jul 17, 2025

View reviewed changes

Adding support to external MariaDB server

40d86d3

wfelipew force-pushed the external-mariadb branch from 6805491 to 40d86d3 Compare July 18, 2025 19:33

		// +kubebuilder:printcolumn:name="Primary",type="string",JSONPath=".status.currentPrimary"
		// +kubebuilder:printcolumn:name="Updates",type="string",JSONPath=".spec.updateStrategy.type"

	pp := corev1.PullIfNotPresent
	return pp
	return corev1.PullIfNotPresent

	return nil
	return nil // ExternalMariaDB uses official MariaDB images (publicly available) for the Backups

	return fmt.Sprintf("mariadb:%s", m.Status.Version)
	return fmt.Sprintf("mariadb:%s", m.Status.Version) // // ExternalMariaDB uses official MariaDB images (publicly available) for the Backups

Adding support to external MariaDB server #1311

Are you sure you want to change the base?

Adding support to external MariaDB server #1311

Uh oh!

Conversation

wfelipew commented Jun 30, 2025

Uh oh!

mmontes11 commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmontes11 commented Jul 16, 2025

Uh oh!

wfelipew commented Jul 16, 2025

Uh oh!

mmontes11 commented Jul 16, 2025

Uh oh!

mmontes11 left a comment

Choose a reason for hiding this comment

Uh oh!

mmontes11 Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmontes11 Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wfelipew commented Jul 18, 2025

Uh oh!

wfelipew commented Jul 18, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

mmontes11 commented Jul 1, 2025 •

edited

Loading

mmontes11 Jul 17, 2025 •

edited

Loading

mmontes11 Jul 17, 2025 •

edited

Loading