Skip to content

Adding support to external MariaDB server #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding support to external MariaDB server #1311

wants to merge 1 commit into from

Conversation

wfelipew
Copy link
Contributor

Adding support to external MariaDB server as requested on #199.

It supports:

  • Connections
  • Users
  • Grants
  • Databases
  • Backups
  • SQLJobs

@wfelipew wfelipew mentioned this pull request Jun 30, 2025
Open
@mmontes11
Copy link
Member

mmontes11 commented Jul 1, 2025 •
edited
Loading

Thanks for raising this @wfelipew . Will take a closer look in the following weeks and let you know. Do you mind rebasing with main?

@wfelipew wfelipew force-pushed the external-mariadb branch from 9fa7ae3 to bd01bda Compare July 1, 2025 09:43
@mmontes11
Copy link
Member

Hey @wfelipew ! As we get close to the 25.08 release, I'm finally finding some time to review this. Would you mind resolving the conflicts and rebasing?

@wfelipew wfelipew force-pushed the external-mariadb branch 6 times, most recently from 4085384 to 59e9091 Compare July 16, 2025 19:47
@wfelipew
Copy link
Contributor Author

Hey @wfelipew ! As we get close to the 25.08 release, I'm finally finding some time to review this. Would you mind resolving the conflicts and rebasing?

done

@mmontes11 mmontes11 self-assigned this Jul 16, 2025
@mmontes11
Copy link
Member

Thanks for the effort @wfelipew ! Looks promising, will take a look tomorrow.

@mmontes11 mmontes11 self-requested a review July 17, 2025 15:46
mmontes11
mmontes11 requested changes Jul 17, 2025
View reviewed changes
Copy link
Member

@mmontes11 mmontes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking the initiative, I do appreciate the effort made here 🙏🏻

Whilst I believe you are on the right track, I think some adaptations are needed, specially around the new abstractions that we have created. Please see my comments, let me know what you think.

pkg/interfaces/interfaces.go
TLSServerCertSecretKey() types.NamespacedName
}

type ReplicationAwareInterface interface {
Copy link
Member

@mmontes11 mmontes11 Jul 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this interface can be removed, please see my previous comments

@wfelipew
Copy link
Contributor Author

Thank you very much for taking the initiative, I do appreciate the effort made here 🙏🏻

Whilst I believe you are on the right track, I think some adaptations are needed, specially around the new abstractions that we have created. Please see my comments, let me know what you think.

Thanks for the review, I'll working on it today

@wfelipew
Copy link
Contributor Author

@mmontes11 I believe I fixed everything except by this one -> #1311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmontes11 mmontes11 mmontes11 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mmontes11 mmontes11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfelipew @mmontes11
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy