-
-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix Line3DCollection with autolim=True for lines of different lengths #30423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MengAiDev
wants to merge
5
commits into
matplotlib:main
Choose a base branch
from
MengAiDev:30420
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8c8db31
Fix Line3DCollection with autolim=True for lines of different lengths
MengAiDev eecd9f8
fix lint
MengAiDev dc320e9
fix lint
MengAiDev 2e72b5a
Add test for Line3DCollection with autolim=True and ragged arrays
MengAiDev c6eaa05
move test
MengAiDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2689,3 +2689,27 @@ def test_ndarray_color_kwargs_value_error(): | |||||
ax = fig.add_subplot(111, projection='3d') | ||||||
ax.scatter(1, 0, 0, color=np.array([0, 0, 0, 1])) | ||||||
fig.canvas.draw() | ||||||
|
||||||
|
||||||
def test_line3dcollection_autolim_ragged(): | ||||||
"""Test Line3DCollection with autolim=True and lines of different lengths.""" | ||||||
fig = plt.figure() | ||||||
ax = fig.add_subplot(projection='3d') | ||||||
|
||||||
# Create lines with different numbers of points (ragged arrays) | ||||||
edges = [ | ||||||
[(0, 0, 0), (1, 1, 1), (2, 2, 2)], # 3 points | ||||||
[(0, 1, 0), (1, 2, 1)], # 2 points | ||||||
[(1, 0, 1), (2, 1, 2), (3, 2, 3), (4, 3, 4)] # 4 points | ||||||
] | ||||||
|
||||||
# This should not raise an exception with the fix | ||||||
collections = ax.add_collection3d(art3d.Line3DCollection(edges), autolim=True) | ||||||
|
||||||
# Check that limits were computed correctly with margins | ||||||
# The limits should include all points with default margins | ||||||
assert np.allclose(ax.get_xlim3d(), (-0.08333333333333333, 4.083333333333333)) | ||||||
assert np.allclose(ax.get_ylim3d(), (-0.0625, 3.0625)) | ||||||
assert np.allclose(ax.get_zlim3d(), (-0.08333333333333333, 4.083333333333333)) | ||||||
|
||||||
plt.close(fig) | ||||||
Comment on lines
+2714
to
+2715
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not needed; all test figures are auto-closed.
Suggested change
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"with the fix" won't make much sense in a few month.