Skip to content

unix/make: Drop i686-linux-gnu path. #17638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

unix/make: Drop i686-linux-gnu path. #17638

merged 1 commit into from
Jul 15, 2025

Conversation

yf13
Copy link
Contributor

@yf13 yf13 commented Jul 8, 2025 •
edited
Loading

Summary

This drops use of non-existing path /usr/include/i686-linux-gnu as default toolchain include paths shall suffice for 32bit.

Testing

Checked locally on amd64 PC host running Ubuntu 22.04 with gcc v11.4 and following configs:

  • make -C ports/unix VARIANT=nanbox MICROPY_PY_FFI=1 test -j4
  • make -C ports/unix MICROPY_FORCE_32BIT=1 test -j4
  • make -C ports/unix test -j4

@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (2743068) to head (aa2362d).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17638   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         171      171           
  Lines       22192    22192           
=======================================
  Hits        21847    21847           
  Misses        345      345

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@yf13 yf13 force-pushed the pull-drop-i686-linux-gnu branch 3 times, most recently from 6def61b to 81cf760 Compare July 8, 2025 23:50
dlech
dlech reviewed Jul 10, 2025
View reviewed changes
tests/extmod/select_poll_eintr.py Outdated
@@ -24,6 +24,7 @@


def thread_main():
global lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lock is not assigned in this function, so we don't need a global statement.

@yf13 yf13 force-pushed the pull-drop-i686-linux-gnu branch 2 times, most recently from 7d24105 to 400dba8 Compare July 10, 2025 22:50
@yf13 yf13 changed the title unix/make: drop i686-linux-gnu unix/make: Drop non-existing i686-linux-gnu. Jul 11, 2025
@yf13 yf13 changed the title unix/make: Drop non-existing i686-linux-gnu. unix/make: Drop i686-linux-gnu path. Jul 11, 2025
@dpgeorge
Copy link
Member

Thanks for the contribution.

The problem with select_poll_eintr.py is described in #11604 (comment) . And I worked around that in #17655. So I think you can drop your changes to that file from this PR and it'll get fixed separately.

@yf13 yf13 force-pushed the pull-drop-i686-linux-gnu branch from 400dba8 to 81cf760 Compare July 11, 2025 19:00
@yf13
Copy link
Contributor Author

yf13 commented Jul 13, 2025

@dpgeorge, thank you for the information. I've dropped it. Please let me know if there are more things to do with this PR.

@yf13 @dpgeorge
unix/Makefile: Drop include path of "i686-linux-gnu".
aa2362d 
This drops use of non-existing path `/usr/include/i686-linux-gnu` as
default include paths shall suffice.

Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
@dpgeorge dpgeorge force-pushed the pull-drop-i686-linux-gnu branch from 81cf760 to aa2362d Compare July 15, 2025 04:03
@dpgeorge dpgeorge merged commit aa2362d into micropython:master Jul 15, 2025
48 checks passed
@yf13 yf13 deleted the pull-drop-i686-linux-gnu branch July 16, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlech dlech dlech left review comments

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
port-unix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yf13 @dpgeorge @dlech
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy