unix/make: Drop i686-linux-gnu path. #17638
Merged
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17638 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 171 171
Lines 22192 22192
=======================================
Hits 21847 21847
Misses 345 345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
6def61b to
81cf760
Compare
dlech
reviewed
Jul 10, 2025
tests/extmod/select_poll_eintr.py
Outdated
| @@ -24,6 +24,7 @@ | |||
|
|
|||
|
|
|||
| def thread_main(): | |||
| global lock | |||
There was a problem hiding this comment.
lock is not assigned in this function, so we don't need a global statement.
7d24105 to
400dba8
Compare
|
Thanks for the contribution. The problem with |
400dba8 to
81cf760
Compare
|
@dpgeorge, thank you for the information. I've dropped it. Please let me know if there are more things to do with this PR. |
This drops use of non-existing path `/usr/include/i686-linux-gnu` as default include paths shall suffice. Signed-off-by: Yanfeng Liu <yfliu2008@qq.com>
dpgeorge
approved these changes
Jul 15, 2025
81cf760 to
aa2362d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This drops use of non-existing path
/usr/include/i686-linux-gnuas default toolchain include paths shall suffice for 32bit.Testing
Checked locally on amd64 PC host running Ubuntu 22.04 with gcc v11.4 and following configs:
make -C ports/unix VARIANT=nanbox MICROPY_PY_FFI=1 test -j4make -C ports/unix MICROPY_FORCE_32BIT=1 test -j4make -C ports/unix test -j4