py/parse: Recognise const int assignments with type hints. #17643
Conversation
|
Code size report: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17643 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 171 171
Lines 22140 22149 +9
=======================================
+ Hits 21749 21758 +9
Misses 391 391 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit extends the parser's behaviour to also recognise constant integer assignments even when the assignment itself has an "int" type annotation. Now declarations like "var: int = const(val)" can be treated as constants by the compiler and thus be folded in the rest of the program as it sees fit. Before this change, that line would generate a variable creation and its value assignment, without any folding being performed. This fixes micropython#15608. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
|
Forgot to add tests... thank you, codecov! I've also had the chance to reword the commit message as it wasn't entirely clear. I'll push the lot once the current test run is over to avoid having to receive loads of cancelled run reports. Anyway, I wonder how difficult it would be to have something like |
Summary
This PR extends the parser's behaviour to also recognise constant integer assignments even when the assignment itself has an "int" type annotation.
Now declarations like "var: int = const(val)" can be treated as constants by the compiler and thus be folded in the rest of the program as it sees fit. Before this change, that line would generate a variable creation and its value assignment, without any folding being performed.
This fixes #15608.
Testing
This was tested using the same verification methodology described in #15608, and the Unix test suite was ran locally without errors with this change applied.
Trade-offs and Alternatives
I've limited the type checking to
inttypes, which I hope it's all that's needed. It can probably be improved style-wise, but from what I reckon the logic should be correct - I haven't looked at the parser since the rv32 inline asm days.