Skip to content

lib/pico-sdk: Fix Pico SDK fetching develop picotool. #17741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lib/pico-sdk: Fix Pico SDK fetching develop picotool. #17741

wants to merge 1 commit into from

Conversation

Gadgetoid
Copy link
Contributor

SDK 2.1.1 shipped with PICOTOOL_FETCH_FROM_GIT configured to fetch the "develop" branch. This eventually broke (my) downstream CI, which was trusting Pico SDK to fetch the correct version.

  1. Mistake in Pico SDK corrected - raspberrypi/pico-sdk@9a4113f
  2. Breaking change added to Picotool - Add support for CYW43_FIRMWARE_FAMILY_ID raspberrypi/picotool#247
  3. I have a bad day - Picotool breaking (all?) CI builds raspberrypi/picotool#256

RPi have added a "2.1.1-correct-picotool" tag which fixes this, and this PR bumps the Pico SDK submodule to that new tag.

Aside from a small documentation change there are no other changes to Pico SDK with this submodule bump.

I don't know how widespread this breakage might be, but since I rely on PICOTOOL_FETCH_FROM_GIT in continuous integration (please, spare your judgement as to the wisdom of this choice) it broke CI across basically every downstream build of MicroPython I maintain... more than a couple... and might cause similar frustrations for other users since MicroPython is still referencing a broken version of Pico SDK.

Note: While picotool has been fixed in the interim so that the develop version no longer causes a build breakage, there's no guarantee that it wont do so again.

@Gadgetoid
lib/pico-sdk: Fix Pico SDK fetching develop picotool.
37bd1c0 
SDK 2.1.1 shipped with PICOTOOL_FETCH_FROM_GIT configured to fetch the
"develop" branch. This broke downstream CI, which was trusting Pico
SDK to fetch the correct version.

RPi have added a "2.1.1-correct-picotool" tag which fixes this.

lib/pico-sdk: Bump to "2.1.1-correct-picotool" tag.

Signed-off-by: Phil Howard <github@gadgetoid.com>
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (e993f53) to head (37bd1c0).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17741   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         171      171           
  Lines       22210    22210           
=======================================
  Hits        21857    21857           
  Misses        353      353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lurch
Copy link
Contributor

lurch commented Jul 22, 2025

Note: While picotool has been fixed in the interim so that the develop version no longer causes a build breakage, there's no guarantee that it wont do so again.

Just to clarify this point slightly: We (by which I mean Raspberry Pi) guarantee that:

  • the develop branches of pico-sdk and picotool will remain compatible with each other
  • the master branches of pico-sdk and picotool will remain compatible with each other
  • the 2.1.1 release of pico-sdk and the 2.1.1 release of picotool will remain compatible with each other

What we explicitly don't guarantee is that the develop branch of picotool and the master branch of pico-sdk (or vice-versa) will remain compatible with each other.

What happened in raspberrypi/picotool#256 is that the 2.1.1 release-tag of pico-sdk mistakenly referenced the develop branch of pictotool rather than the 2.1.1 release-tag of picotool. And then a later update to the develop branch of picotool made a change which wasn't backwards-compatible with the 2.1.1 release of pico-sdk (and this is what broke all of @Gadgetoid 's CI).
The pico-sdk 2.1.1-correct-picotool is an "updated" version of the 2.1.1 release-tag with the pictool version updated to its 2.1.1 release-tag.

@lurch lurch mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-rp2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gadgetoid @lurch @dpgeorge
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy