Skip to content

Add support for CYW43_FIRMWARE_FAMILY_ID #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2025
Merged

Add support for CYW43_FIRMWARE_FAMILY_ID #247

merged 2 commits into from
Jul 18, 2025

Conversation

will-v-pi
Copy link
Contributor

Corresponds to raspberrypi/pico-sdk#1969

@will-v-pi will-v-pi added this to the 2.1.2 milestone Jun 20, 2025
@will-v-pi will-v-pi mentioned this pull request Jun 20, 2025
Merged
@lurch lurch changed the title Add support for WIFI_FIRMWARE_FAMILY_ID Add support for CYW43_FIRMWARE_FAMILY_ID Jun 25, 2025
@will-v-pi will-v-pi merged commit 1c65fa9 into develop Jul 18, 2025
40 of 76 checks passed
@will-v-pi will-v-pi deleted the pico2-w-pts branch July 18, 2025 08:41
@anobit
Copy link

anobit commented Jul 18, 2025

These changes break the pico-sdk, building for RP2040:


[build] /project/build/_deps/picotool-src/main.cpp: In lambda function:
[build] /project/build/_deps/picotool-src/main.cpp:376:21: error: 'CYW43_FIRMWARE_FAMILY_ID' was not declared in this scope
[build]   376 |                 t = CYW43_FIRMWARE_FAMILY_ID;
[build]       |                     ^~~~~~~~~~~~~~~~~~~~~~~~
[build] /project/build/_deps/picotool-src/main.cpp: In function 'std::string family_name(unsigned int)':
[build] /project/build/_deps/picotool-src/main.cpp:412:22: error: 'CYW43_FIRMWARE_FAMILY_ID' was not declared in this scope
[build]   412 |     if (family_id == CYW43_FIRMWARE_FAMILY_ID) return "'" + cyw43_firmware_family_name + "'";
[build]       |                      ^~~~~~~~~~~~~~~~~~~~~~~~
[build] /project/build/_deps/picotool-src/main.cpp: In member function 'virtual bool partition_create_command::execute(device_map&)':
[build] /project/build/_deps/picotool-src/main.cpp:6391:22: error: 'BOOTROM_FAMILY_ID_MIN' was not declared in this scope
[build]  6391 |             if (id < BOOTROM_FAMILY_ID_MIN || id > BOOTROM_FAMILY_ID_MAX) {
[build]       |                      ^~~~~~~~~~~~~~~~~~~~~
[build] /project/build/_deps/picotool-src/main.cpp:6391:52: error: 'BOOTROM_FAMILY_ID_MAX' was not declared in this scope
[build]  6391 |             if (id < BOOTROM_FAMILY_ID_MIN || id > BOOTROM_FAMILY_ID_MAX) {
[build]       |                                                    ^~~~~~~~~~~~~~~~~~~~~
[build] ninja: build stopped: subcommand failed.
[build] ninja: build stopped: subcommand failed.

Sadly, the pico sdk on version 2.1.1 pulls this change on new cmake build directory; thus destroying CI builds which worked prior to this.

@anobit anobit mentioned this pull request Jul 18, 2025
Closed
@will-v-pi
Copy link
Contributor Author

The current master branch of pico-sdk fixes that issue, or alternatively you can build and install picotool separately following the instructions in the readme, or copying the CI jobs in this repo.

@Gadgetoid Gadgetoid mentioned this pull request Jul 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@will-v-pi @anobit
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy