Skip to content

extmod/modbluetooth: Make UUID support the buffer protocol. #5236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2019
Merged

extmod/modbluetooth: Make UUID support the buffer protocol. #5236

merged 3 commits into from
Oct 22, 2019

Conversation

jimmo
Copy link
Member

@jimmo jimmo commented Oct 21, 2019

This allows UUIDs to be easily used in BLE payloads (such as advertising).

Add this to the advertising example.

Ref: #5186

dpgeorge
dpgeorge reviewed Oct 21, 2019
View reviewed changes
@jimmo jimmo force-pushed the ble-uuid-buffer branch 2 times, most recently from db6935e to 651e80b Compare October 22, 2019 01:32
@jimmo
Copy link
Member Author

jimmo commented Oct 22, 2019

Thanks, addressed all the comments and split the commits.

The UUID is now internally LE, the public interface is still the same.

Added the objstr change as another commit.

dpgeorge
dpgeorge reviewed Oct 22, 2019
View reviewed changes
dpgeorge
dpgeorge reviewed Oct 22, 2019
View reviewed changes
@jimmo
Copy link
Member Author

jimmo commented Oct 22, 2019

Thanks, done!

dpgeorge
dpgeorge reviewed Oct 22, 2019
View reviewed changes
jimmo added 3 commits October 22, 2019 13:54
@jimmo
extmod/modbluetooth: Make UUID support the buffer protocol.
56fc3ed 
Internally change the representation of UUIDs to LE uint8* to simplify this.

This allows UUIDs to be easily used in BLE payloads (such as advertising).

Ref: micropython#5186
@jimmo
examples/bluetooth: Use UUIDs directly to add services to adv payload.
3e1af5b
@jimmo
py/objstr: Size-optimise failure path for mp_obj_str_get_buffer.
c7ae8c5 
These fields are never looked at if the function returns non-zero.
@jimmo
Copy link
Member Author

jimmo commented Oct 22, 2019

Done

@dpgeorge dpgeorge merged commit c7ae8c5 into micropython:master Oct 22, 2019
@dpgeorge
Copy link
Member

Thanks!

@jimmo jimmo mentioned this pull request Oct 22, 2019
Open
13 tasks
@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge left review comments

Assignees
No one assigned
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimmo @dpgeorge
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy