fix: resolve npm package with .js in the name #227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Brooooooklyn and the rest of your teammates on |
CodSpeed Performance ReportMerging #227 will not alter performanceComparing Summary
|
e79dc0f to
c8c7803
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 07-15-ci_add_x86_64-unknown-freebsd_target #227 +/- ##
==============================================================================
+ Coverage 96.95% 96.96% +0.01%
==============================================================================
Files 11 11
Lines 2297 2308 +11
==============================================================================
+ Hits 2227 2238 +11
Misses 70 70 ☔ View full report in Codecov by Sentry. |
ematipico
approved these changes
Jul 15, 2024
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
72f9fb5 to
888cd9b
Compare
6f58d3c to
8a8ecd9
Compare
Base automatically changed from
07-15-ci_add_x86_64-unknown-freebsd_target
to
main
July 15, 2024 09:35
ematipico
approved these changes
Jul 15, 2024
Boshen
reviewed
Jul 15, 2024
| /// If the extension alias is enabled and all of the aliased extensions are not found if: | ||
| /// 1. in `node_modules`, we can fallback to the original extension; | ||
| /// 2. not in `node_modules`, it should not allow to fallback to the original extension or add new extensions. | ||
| pub resolve_in_node_modules: bool, |
There was a problem hiding this comment.
🤔 Let me take a look at the problem first 😅
Boshen
added a commit
that referenced
this pull request
Jul 15, 2024
Boshen
added a commit
that referenced
this pull request
Jul 15, 2024
Boshen
added a commit
that referenced
this pull request
Jul 15, 2024
JounQin
pushed a commit
that referenced
this pull request
Jul 6, 2025
* chore: update lockfiles * Release v1.9.4 * feat(napi): expose module type info in ResolveResult (#223) * chore: update devDependencies * Release v1.10.0 * fix(napi): update buggy NAPI-RS versions (#225) fix(napi): update buggy @napi-rs/cli * ci: all `--all-features` to various commands * chore(deps): update crate-ci/typos action to v1.23.2 * chore(deps): update rust crate napi to 3.0.0-alpha * chore(deps): update rust crates * ci: add x86_64-unknown-freebsd target (#226) * fix: resolve module `ipaddr.js` correctly when `extensionAlias` is provided (#228) closes #227 * Release v1.10.1 * ci: fix FreeBSD build (#230) * ci: add `needs` check in build-freebsd * ci: publish needs build-freebsd (#232) * Release v1.10.2 * feat: Yarn PnP (#217) Part of #53 * chore(deps): update rust crate napi-derive to 3.0.0-alpha * chore(deps): update rust crates * chore(deps): fix the lock --------- Co-authored-by: Boshen <boshenc@gmail.com> Co-authored-by: LongYinan <lynweklm@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maël Nison <nison.mael@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: swc-project/swc-node#817