Skip to content

A small flaw regarding the deployments table. #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frg01 opened this issue Jan 3, 2024 · 3 comments
Closed

A small flaw regarding the deployments table. #1264

frg01 opened this issue Jan 3, 2024 · 3 comments

Comments

@frg01
Copy link

frg01 commented Jan 3, 2024

A default mechanism for train deployment is best_score, but why is the strategy field in the deployments table a fixed value most_recent? If it is to record the strategy during deployment, then it is best to be a variable. If it is to query during deployment, then it It seems like another redundant field. Maybe I don’t understand this table well enough. If possible, I’d like to ask you for advice!

`select pgml.train(
project_name => 'Diabetes Regression',
task => 'regression',
relation_name => 'pgml.diabetes',
y_column_name => 'target',
algorithm=> 'linear'
);

select * from pgml.deployments
results :
id | project_id | model_id | strategy | created_at
----+------------+----------+-------------+----------------------------
3 | 2 | 4 | most_recent | 2024-01-03 10:52:12.474621
5 | 2 | 7 | most_recent | 2024-01-03 10:55:03.908885
4 | 2 | 5 | most_recent | 2024-01-03 10:54:20.831898
2 | 2 | 2 | most_recent | 2024-01-03 10:47:02.574409
1 | 1 | 1 | most_recent | 2024-01-03 10:29:18.626135

`

Thank you for your continuous explanations these days. If I find new problems, I may need to trouble you. Thank you more.

@montanalow
Copy link
Contributor

montanalow commented Jan 3, 2024

This is a bug in https://github.com/postgresml/postgresml/blob/master/pgml-extension/src/orm/project.rs#L99

We should make this function take a parameter with the correct strategy to record in the database.

To address question 4 in #1259 we should also expose this function to deploy by model.id in the api with a new "manual" strategy.

@montanalow
Copy link
Contributor

fixed with #1265

@frg01
Copy link
Author

frg01 commented Jan 4, 2024

fixed with #1265

Wow, you are so quick at fixing bugs. It’s faster than I can find bugs. You are really awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy