gh-134861: Add CSV and 🍌SV output formats to `asyncio ps` #134862

dpdani · 2025-05-28T18:29:57Z

Issue: Add CSV and 🍌SV output formats to asyncio ps #134861

# Conflicts: # Lib/asyncio/tools.py

ZeroIntensity · 2025-05-28T19:52:20Z

(Skipping news because this is an easter egg)

johnzhou721 · 2025-05-28T21:14:25Z

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

ZeroIntensity · 2025-05-28T21:41:29Z

Oh, hm. I guess we could add an entry for only CSV. I'll leave the decision to @dpdani.

Lib/asyncio/tools.py

AA-Turner · 2025-05-29T02:36:58Z

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

Yes, please add news for CSV format

johnzhou721

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

Lib/asyncio/tools.py

AA-Turner · 2025-05-29T09:19:33Z

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

We're not trying to hide or obsfucate; just not to advertise.

Lib/asyncio/__main__.py

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

python-cla-bot · 2025-05-29T17:32:41Z

All commit authors signed the Contributor License Agreement.

johnzhou721 · 2025-05-29T18:21:20Z

Sure, resolve.

# Conflicts: # Lib/asyncio/tools.py

johnzhou721 · 2025-06-20T21:18:15Z

Lib/asyncio/tools.py

@@ -264,7 +264,7 @@ def display_awaited_by_tasks_table(
 def _display_awaited_by_tasks_table(table) -> None:
    # Print the table in a simple tabular format
    print(
-        f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<20} {_header[5]:<15}"
+        f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<50} {_header[5]:<15} {_header[6]:<15}"


Try storing the numbers in either another array or a tulle with headers and for loop this print.

Hi John 👋

I don't think it would make the code significantly cleaner, if that was your intent.
Also those numbers are only used in this function so it makes sense they only appear here.
My guess is you want to avoid the repetition of the numbers on line 271 below, but again I don't think it's particularly harmful.

Feel free to disagree, but writing header[0] header[1] etc makes it hard to read which property is associated with which length.

Thank you for your consideration.

I agree that the proposed change is harder to read/comprehend; reverting would be helpful.

dpdani · 2025-08-01T18:02:31Z

can someone give this another look?

AA-Turner · 2025-08-01T18:05:11Z

Lib/asyncio/tools.py

@@ -264,7 +264,7 @@ def display_awaited_by_tasks_table(
 def _display_awaited_by_tasks_table(table) -> None:
    # Print the table in a simple tabular format
    print(
-        f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<20} {_header[5]:<15}"
+        f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<50} {_header[5]:<15} {_header[6]:<15}"


I agree that the proposed change is harder to read/comprehend; reverting would be helpful.

AA-Turner · 2025-08-01T18:05:37Z

Lib/asyncio/tools.py

@@ -5,6 +5,8 @@
 from enum import Enum
 import sys
 from _remote_debugging import RemoteUnwinder, FrameInfo
+import csv


Please keep the list sorted

AA-Turner · 2025-08-01T18:08:50Z

Lib/asyncio/tools.py

+    # As per the words of the asyncio 🍌SV spec lead:
+    # > 🍌SV is not just a format. It’s a lifestyle. A philosophy.


What's the "🍌SV spec"? I don't recall CSV/etc being mentioned in the talk. Perhaps just keep the epigraph (with a time code link, the youtube transcript doesn't have results for the quotation).

It was a reference to this comment: #134861 (comment)

In that case, shall we use the more relevant link?

Or should we keep just the quote?

AA-Turner · 2025-08-01T18:10:08Z

Lib/asyncio/tools.py

+def display_awaited_by_tasks_table(
+        pid: int,
+        format_: TaskTableOutputFormat | str = TaskTableOutputFormat.table
+    ) -> None:


Also remove the underscore from format_?

Suggested change

def display_awaited_by_tasks_table(

pid: int,

format_: TaskTableOutputFormat | str = TaskTableOutputFormat.table

) -> None:

def display_awaited_by_tasks_table(pid, format_=TaskTableOutputFormat.table):

I have not removed the type annotations because they were already otherwise present in this file

They're needlessly verbose here, hence the suggestion.

Lib/asyncio/tools.py

Misc/NEWS.d/next/Library/2025-05-29-19-00-37.gh-issue-134861.y2-fu-.rst

…2-fu-.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

picnixz

I hate to be the not-funny one here but, while I think it's ok to have the CSV format, I would honestly prefer that we don't slip secret formats in this PR. The #119535 easter egg had a separate issue and PR and I would honestly prefer that for this one.

Lib/asyncio/tools.py

dpdani · 2025-08-01T21:32:36Z

I hate to be the not-funny one here but, while I think it's ok to have the CSV format, I would honestly prefer that we don't slip secret formats in this PR. The #119535 easter egg had a separate issue and PR and I would honestly prefer that for this one.

I think there's not much point duplicating the issue now, but splitting into two PRs can make sense.

@picnixz if you really think it's best, I can do the split.

picnixz · 2025-08-01T21:45:25Z

Yeah no need for two issues, but I would really like two separate PRs. For people reading commits, it's easier to spot the easter egg and it also makes reverting easier (if needed). It also allows us to make a funnier commit message. However, if @1st1 or any other codeowner is ok with adding the easter egg in this PR, I won't oppose their decision.

EDIT: I pinged the wrong code owner

Add CSV and 🍌SV output formats to asyncio ps

cf70073

dpdani requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners May 28, 2025 18:29

bedevere-app bot mentioned this pull request May 28, 2025

Add CSV and 🍌SV output formats to asyncio ps #134861

Open

bedevere-app bot added the awaiting review label May 28, 2025

Merge branch 'main' into feature/pending-tasks-csv-bsv

75d0b14

# Conflicts: # Lib/asyncio/tools.py

ZeroIntensity added the skip news label May 28, 2025

AA-Turner reviewed May 29, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

johnzhou721 suggested changes May 29, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting core review and removed awaiting review labels May 29, 2025

johnzhou721 reviewed May 29, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

johnzhou721 reviewed May 29, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

nineteendo reviewed May 29, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

ZeroIntensity removed the skip news label May 29, 2025

danielhollas reviewed May 29, 2025

View reviewed changes

Lib/asyncio/__main__.py Outdated Show resolved Hide resolved

Update Lib/asyncio/tools.py

4b77995

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Move table output to separate function

f5132c9

📜🤖 Added by blurb_it.

cd11ad7

This comment was marked as outdated.

Sign in to view

explain why 🍌s are relevant

21b581a

make it a secret 🤫

e44226d

johnzhou721 approved these changes May 31, 2025

View reviewed changes

Merge branch 'main' into feature/pending-tasks-csv-bsv

fe3cf6c

# Conflicts: # Lib/asyncio/tools.py

johnzhou721 reviewed Jun 20, 2025

View reviewed changes

dpdani requested a review from AA-Turner August 1, 2025 18:02

AA-Turner reviewed Aug 1, 2025

View reviewed changes

Update Misc/NEWS.d/next/Library/2025-05-29-19-00-37.gh-issue-134861.y…

58da049

…2-fu-.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

picnixz reviewed Aug 1, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

review

a1f69b6

picnixz reviewed Aug 1, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

review

60cd13b

AA-Turner reviewed Aug 1, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

ZeroIntensity reviewed Aug 1, 2025

View reviewed changes

Lib/asyncio/tools.py Outdated Show resolved Hide resolved

dpdani added 2 commits August 1, 2025 23:20

review

3fd565d

review

c38f929

		# As per the words of the asyncio 🍌SV spec lead:
		# > 🍌SV is not just a format. It’s a lifestyle. A philosophy.

Uh oh!

gh-134861: Add CSV and 🍌SV output formats to asyncio ps #134862

Are you sure you want to change the base?

gh-134861: Add CSV and 🍌SV output formats to asyncio ps #134862

Uh oh!

Conversation

dpdani commented May 28, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity commented May 28, 2025

Uh oh!

johnzhou721 commented May 28, 2025

Uh oh!

ZeroIntensity commented May 28, 2025

Uh oh!

Uh oh!

AA-Turner commented May 29, 2025

Uh oh!

johnzhou721 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

python-cla-bot bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnzhou721 commented May 29, 2025 via email

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpdani commented Aug 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpdani commented Aug 1, 2025

Uh oh!

picnixz commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

gh-134861: Add CSV and 🍌SV output formats to `asyncio ps` #134862

gh-134861: Add CSV and 🍌SV output formats to `asyncio ps` #134862

dpdani commented May 28, 2025 •

edited by bedevere-app bot

Loading

AA-Turner commented May 29, 2025 •

edited

Loading

python-cla-bot bot commented May 29, 2025 •

edited

Loading

picnixz commented Aug 1, 2025 •

edited

Loading