-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-134861: Add CSV output format to asyncio ps
#134862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # Lib/asyncio/tools.py
(Skipping news because this is an easter egg) |
@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news? |
Oh, hm. I guess we could add an entry for only CSV. I'll leave the decision to @dpdani. |
Yes, please add news for CSV format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.
We're not trying to hide or obsfucate; just not to advertise. |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sure, resolve.
|
I think there's not much point duplicating the issue now, but splitting into two PRs can make sense. @picnixz if you really think it's best, I can do the split. |
Yeah no need for two issues, but I would really like two separate PRs. For people reading commits, it's easier to spot the easter egg and it also makes reverting easier (if needed). It also allows us to make a funnier commit message. However, if @1st1 or any other codeowner is ok with adding the easter egg in this PR, I won't oppose their decision. EDIT: I pinged the wrong code owner |
I'll split the PR now |
asyncio ps
asyncio ps
Split done. The CSV format is here and the news entry is already ok. |
As far as I can tell there are no existing tests for this, #133284 has some for |
Yeah, I saw it didn't have tests before and didn't think it would be necessary to add them here. What do you think? |
Ah ok, you enabled auto-merge, I guess it's ok 👍 Thank you! |
asyncio ps
#134861