Skip to content

gh-134861: Add CSV output format to asyncio ps #134862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 6, 2025

Conversation

dpdani
Copy link
Contributor

@dpdani dpdani commented May 28, 2025

# Conflicts:
#	Lib/asyncio/tools.py
@ZeroIntensity
Copy link
Member

(Skipping news because this is an easter egg)

@johnzhou721
Copy link
Contributor

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

@ZeroIntensity
Copy link
Member

Oh, hm. I guess we could add an entry for only CSV. I'll leave the decision to @dpdani.

@AA-Turner
Copy link
Member

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

Yes, please add news for CSV format

Copy link
Contributor

@johnzhou721 johnzhou721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

@AA-Turner
Copy link
Member

AA-Turner commented May 29, 2025

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

We're not trying to hide or obsfucate; just not to advertise.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@python-cla-bot
Copy link

python-cla-bot bot commented May 29, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@johnzhou721
Copy link
Contributor

johnzhou721 commented May 29, 2025 via email

johnzhou721

This comment was marked as outdated.

@dpdani
Copy link
Contributor Author

dpdani commented Aug 1, 2025

I hate to be the not-funny one here but, while I think it's ok to have the CSV format, I would honestly prefer that we don't slip secret formats in this PR. The #119535 easter egg had a separate issue and PR and I would honestly prefer that for this one.

I think there's not much point duplicating the issue now, but splitting into two PRs can make sense.

@picnixz if you really think it's best, I can do the split.

@picnixz
Copy link
Member

picnixz commented Aug 1, 2025

Yeah no need for two issues, but I would really like two separate PRs. For people reading commits, it's easier to spot the easter egg and it also makes reverting easier (if needed). It also allows us to make a funnier commit message. However, if @1st1 or any other codeowner is ok with adding the easter egg in this PR, I won't oppose their decision.

EDIT: I pinged the wrong code owner

@dpdani
Copy link
Contributor Author

dpdani commented Aug 6, 2025

I'll split the PR now

@dpdani dpdani changed the title gh-134861: Add CSV and 🍌SV output formats to asyncio ps gh-134861: Add CSV output format to asyncio ps Aug 6, 2025
@dpdani
Copy link
Contributor Author

dpdani commented Aug 6, 2025

Split done.

The CSV format is here and the news entry is already ok.
Bananas in #137486

@AA-Turner
Copy link
Member

As far as I can tell there are no existing tests for this, #133284 has some for build_task_table() and build_async_tree(), but not for display_awaited_by_tasks_table().

@AA-Turner AA-Turner enabled auto-merge (squash) August 6, 2025 19:52
@dpdani
Copy link
Contributor Author

dpdani commented Aug 6, 2025

Yeah, I saw it didn't have tests before and didn't think it would be necessary to add them here.
It was just a bunch of prints before, now there's a bit more logic, but still not a lot to test for, IMHO.

What do you think?

@dpdani
Copy link
Contributor Author

dpdani commented Aug 6, 2025

Ah ok, you enabled auto-merge, I guess it's ok 👍

Thank you!

@AA-Turner AA-Turner merged commit 470cbe9 into python:main Aug 6, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy