gh-133125: Clarify ZipInfo.date_time attribute documentation #136082
Conversation
…f timestamp and limitations
|
This is how it looks like |
There was a problem hiding this comment.
@KentaroJay thanks for the PR! Would you be interested in adding information about the way CPython interprets the timezone of the datetime (i.e. the time is interpreted as the local timezone). This was brought up in #123059.
I can do that in a follow up if you'd prefer to keep this focused on just covering the source of the timestamp information.
| @@ -818,7 +818,18 @@ Instances have the following methods and attributes: | |||
| .. attribute:: ZipInfo.date_time | |||
|
|
|||
| The time and date of the last modification to the archive member. This is a | |||
| tuple of six values: | |||
| tuple of six values representing the "last mod file time" and "last mod file date" | |||
There was a problem hiding this comment.
| tuple of six values representing the "last mod file time" and "last mod file date" | |
| tuple of six values representing the "last [modified] file time" and "last [modified] file date" |
I realize you are using the text from APPNOTE.txt here, but I think we should expand the word to be a bit clearer.
| specifically returns the timestamp from the central directory. Future Python | ||
| versions may use alternative timestamp sources if they provide better accuracy | ||
| or precision. |
There was a problem hiding this comment.
| specifically returns the timestamp from the central directory. Future Python | |
| versions may use alternative timestamp sources if they provide better accuracy | |
| or precision. | |
| specifically returns the timestamp from the central directory. |
I don't think we can change the source of date_time in a backwards compatible way.
| tuple of six values representing the "last mod file time" and "last mod file date" | ||
| fields from the ZIP file's central directory. | ||
|
|
||
| .. note:: |
There was a problem hiding this comment.
I would move this note further down as "a tuple of six values" is lost as context when you get to "The tuple" below.
There was a problem hiding this comment.
The note also seems very similar to the one below. I would merge the information in this note into the one below.
|
@emmatyping |
zipfile: docs should document whatZipInfo.date_timeactually is #133125📚 Documentation preview 📚: https://cpython-previews--136082.org.readthedocs.build/