Skip to content

gh-133125: Clarify ZipInfo.date_time attribute documentation #136082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −2
Open

gh-133125: Clarify ZipInfo.date_time attribute documentation #136082

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
849e275
Clarify ZipInfo.date_time attribute documentation to specify source o…
KentaroJay Jun 28, 2025
fcad6c5
Fix
KentaroJay Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions Doc/library/zipfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,18 @@ Instances have the following methods and attributes:
.. attribute:: ZipInfo.date_time

The time and date of the last modification to the archive member. This is a
tuple of six values:
tuple of six values representing the "last mod file time" and "last mod file date"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tuple of six values representing the "last mod file time" and "last mod file date"
tuple of six values representing the "last [modified] file time" and "last [modified] file date"

I realize you are using the text from APPNOTE.txt here, but I think we should expand the word to be a bit clearer.

fields from the ZIP file's central directory.

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this note further down as "a tuple of six values" is lost as context when you get to "The tuple" below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note also seems very similar to the one below. I would merge the information in this note into the one below.


The ZIP format supports multiple timestamp fields in different locations
(central directory, extra fields for NTFS/UNIX systems, etc.). This attribute
specifically returns the timestamp from the central directory. Future Python
versions may use alternative timestamp sources if they provide better accuracy
or precision.
Comment on lines +828 to +830
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
specifically returns the timestamp from the central directory. Future Python
versions may use alternative timestamp sources if they provide better accuracy
or precision.
specifically returns the timestamp from the central directory.

I don't think we can change the source of date_time in a backwards compatible way.


The tuple contains:

+-------+--------------------------+
| Index | Value |
Expand All @@ -838,7 +849,10 @@ Instances have the following methods and attributes:

.. note::

The ZIP file format does not support timestamps before 1980.
The central directory timestamp format in ZIP files does not support
timestamps before 1980. While some extra field formats (such as UNIX
timestamps) can represent earlier dates, this attribute only returns
the central directory timestamp.


.. attribute:: ZipInfo.compress_type
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy