gh-136992: Add 'None' as valid SameSite value as per RFC6265bis #137040
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
ZeroIntensity
approved these changes
Jul 24, 2025
|
Thanks for the heads-up! I’ll avoid force-pushing next time. |
picnixz
reviewed
Jul 25, 2025
Comment on lines
+151
to
+155
| The attribute :attr:`samesite` controls when the browser sends the cookie with | ||
| cross-site requests. This helps to mitigate CSRF attacks. Valid values are | ||
| "Strict" (never sent with cross-site requests), "Lax" (sent with top-level | ||
| navigation), and "None" (always sent). When using "None", the "secure" | ||
| attribute must also be set, as required by modern browsers. |
There was a problem hiding this comment.
Suggested change
| The attribute :attr:`samesite` controls when the browser sends the cookie with | |
| cross-site requests. This helps to mitigate CSRF attacks. Valid values are | |
| "Strict" (never sent with cross-site requests), "Lax" (sent with top-level | |
| navigation), and "None" (always sent). When using "None", the "secure" | |
| attribute must also be set, as required by modern browsers. | |
| The attribute :attr:`samesite` controls when the browser sends the cookie with | |
| cross-site requests. This helps to mitigate CSRF attacks. Valid values are | |
| "Strict" (only sent with same-site requests), "Lax" (sent with same-site | |
| requests and top-level navigations), and "None" (sent with same-site and | |
| cross-site requests). When using "None", the "secure" attribute must also | |
| be set, as required by modern browsers. |
Let's use the same wording as the RFC.
picnixz
reviewed
Jul 25, 2025
| "Strict" (never sent with cross-site requests), "Lax" (sent with top-level | ||
| navigation), and "None" (always sent). When using "None", the "secure" | ||
| attribute must also be set, as required by modern browsers. | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing documentation for the samesite attribute in the http.cookies module.
While the attribute was already listed among valid Morsel attributes, it lacked an explanation. This change adds clear and complete documentation explaining:
-The attribute’s role in CSRF protection.
-The valid values: "Strict", "Lax", and "None".
-The requirement that "secure" must be set when using "SameSite=None".
This update brings the documentation in line with RFC6265bis and reflects current browser behaviour.
📚 Documentation preview 📚: https://cpython-previews--137040.org.readthedocs.build/
http.cookiesshould mention thatsamesite=Noneis valid as per RFC6265bis #136992