gh-136992: Add 'None' as valid SameSite value as per RFC6265bis #137040
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
ZeroIntensity
approved these changes
Jul 24, 2025
|
Thanks for the heads-up! I’ll avoid force-pushing next time. |
picnixz
reviewed
Jul 25, 2025
picnixz
reviewed
Jul 25, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Jul 26, 2025
picnixz
reviewed
Jul 26, 2025
picnixz
reviewed
Jul 26, 2025
picnixz
reviewed
Jul 26, 2025
picnixz
approved these changes
Jul 27, 2025
|
Now, don't touch your branch at all. No need to update it either. |
|
Thanks @iqra-codes for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2025
…bis (pythonGH-137040) The "SameSite" attribute defined in RFC 6265bis [1] allows the "Strict", "Lax" and "None" enforcement modes. We already documented "Strict" and "Lax" as being valid values but "None" was missing from the list. While the RFC has not been formally approved, modern browsers support the "None" value [2, 3] thereby making sense to document it. [1]: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis [2]: https://developers.google.com/search/blog/2020/01/get-ready-for-new-samesitenone-secure [3]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie#none --------- (cherry picked from commit ae8b7d7) Co-authored-by: Iqra Khan <iqraakhan2519@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
Thank you for the contribution! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 27, 2025
…bis (pythonGH-137040) The "SameSite" attribute defined in RFC 6265bis [1] allows the "Strict", "Lax" and "None" enforcement modes. We already documented "Strict" and "Lax" as being valid values but "None" was missing from the list. While the RFC has not been formally approved, modern browsers support the "None" value [2, 3] thereby making sense to document it. [1]: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis [2]: https://developers.google.com/search/blog/2020/01/get-ready-for-new-samesitenone-secure [3]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie#none --------- (cherry picked from commit ae8b7d7) Co-authored-by: Iqra Khan <iqraakhan2519@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-137140 is a backport of this pull request to the 3.14 branch. |
|
GH-137141 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Jul 27, 2025
…5bis (GH-137040) (#137141) gh-136992: Add "None" as valid `SameSite` value as per RFC 6265bis (GH-137040) The "SameSite" attribute defined in RFC 6265bis [1] allows the "Strict", "Lax" and "None" enforcement modes. We already documented "Strict" and "Lax" as being valid values but "None" was missing from the list. While the RFC has not been formally approved, modern browsers support the "None" value [2, 3] thereby making sense to document it. [1]: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis [2]: https://developers.google.com/search/blog/2020/01/get-ready-for-new-samesitenone-secure [3]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Set-Cookie#none --------- (cherry picked from commit ae8b7d7) Co-authored-by: Iqra Khan <iqraakhan2519@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing documentation for the samesite attribute in the http.cookies module.
While the attribute was already listed among valid Morsel attributes, it lacked an explanation. This change adds clear and complete documentation explaining:
-The attribute’s role in CSRF protection.
-The valid values: "Strict", "Lax", and "None".
-The requirement that "secure" must be set when using "SameSite=None".
This update brings the documentation in line with RFC6265bis and reflects current browser behaviour.
📚 Documentation preview 📚: https://cpython-previews--137040.org.readthedocs.build/
http.cookiesshould mention thatsamesite=Noneis valid as per RFC6265bis #136992