Skip to content

GH-137218: Update make for JIT stencils #137265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

GH-137218: Update make for JIT stencils #137265

wants to merge 18 commits into from
+32 −15

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Jul 31, 2025 •
edited
Loading

This PR normalizes stencil names and then modifies the Makefile to select the appropriate JIT stencil header based on the host.

@bedevere-app bedevere-app bot mentioned this pull request Jul 31, 2025
Open
@savannahostrowski savannahostrowski added skip news build The build process and cross-build topic-JIT labels Jul 31, 2025
@savannahostrowski
Copy link
Member Author

savannahostrowski commented Jul 31, 2025 •
edited
Loading

Fixes the segfault on my machine but feel free to test if we think there's anything dubious here. I opted to remove the autoconf substitution here since this seems pretty straightforward.

@brandtbucher
Copy link
Member

Could we do jit_stencils*.h to catch both files with one pattern?

Also, does the PCbuild logic need to be updated? Or is it good?

@savannahostrowski
Copy link
Member Author

I'm no make expert, but based on my testing and what I've read, it seems like the wildcard keyword is required for proper glob expansion in Makefiles. It doesn't expand out in the same way as it would in a shell with * (see failed commits above 🫠 ). Windows should be good since we explicitly enumerate the stencils by platform.

That said...I...I am truly perplexed as I can no longer reproduce the segfault. The first commit from last night fixed the issue locally, so I know that this did solve the issue I was seeing, but...????

@brandtbucher Can you still repro?

savannahostrowski
savannahostrowski commented Aug 2, 2025
View reviewed changes
@savannahostrowski
Copy link
Member Author

I know what the issue is here, will fix later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

Assignees
No one assigned
Labels
awaiting merge build The build process and cross-build skip news topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savannahostrowski @brandtbucher @Fidget-Spinner
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy