-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
GH-137218: Update make
for JIT stencils
#137265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes the segfault on my machine but feel free to test if we think there's anything dubious here. I opted to remove the autoconf substitution here since this seems pretty straightforward. |
Could we do Also, does the PCbuild logic need to be updated? Or is it good? |
eec5f75
to
ba48cc7
Compare
I'm no That said...I...I am truly perplexed as I can no longer reproduce the segfault. The first commit from last night fixed the issue locally, so I know that this did solve the issue I was seeing, but...???? @brandtbucher Can you still repro? |
I know what the issue is here, will fix later. |
I have the exact same problem, it suddenly stopped crashing and I haven't figured out a way to get into the segfaulting state ever since. So it seems normal for this abnormal issue. |
This PR normalizes stencil names and then modifies the
Makefile
to select the appropriate JIT stencil header based on the host._pyrepl
with low value forJUMP_BACKWARD_INITIAL_VALUE
#137218