-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
GH-136155: Use sphinxext-opengraph
v0.11.0
#137348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @m-aciek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the release, looks good!
A previous PR:
Run python Doc/tools/check-epub.py
Error: must not contain fatal errors:
FATAL - RSC-016 - Python.epub/howto/descriptor.xhtml:11:78 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/logging-cookbook.xhtml:11:62 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/logging.xhtml:11:62 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/regex.xhtml:11:64 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.4.xhtml:11:66 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.5.xhtml:11:71 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.6.xhtml:11:71 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.7.xhtml:11:70 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
https://github.com/python/cpython/actions/runs/16706217793/job/47284695629?pr=137342
This PR:
Run python Doc/tools/check-epub.py
https://github.com/python/cpython/actions/runs/16708070077/job/47288978290?pr=137348
In a separate PR, we can now make the EPUB error check required to pass to prevent regressions, and also add some sort of "No errors found" for the success case rather than no output.
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
(cherry picked from commit 13e21b2) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit 13e21b2) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-137349 is a backport of this pull request to the 3.14 branch. |
GH-137350 is a backport of this pull request to the 3.13 branch. |
See #137351. A |
Like #136406, I expect we'll also need a 3.12 backport. We can wait for confirmation these changes result in a working EPUB for the newer branches. |
📚 Documentation preview 📚: https://cpython-previews--137348.org.readthedocs.build/