Skip to content

GH-136155: Use sphinxext-opengraph v0.11.0 #137348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 3, 2025

@AA-Turner AA-Turner requested a review from hugovk as a code owner August 3, 2025 18:23
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 3, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Aug 3, 2025
@AA-Turner
Copy link
Member Author

cc @m-aciek

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the release, looks good!

A previous PR:

Run python Doc/tools/check-epub.py

Error: must not contain fatal errors:

FATAL - RSC-016 - Python.epub/howto/descriptor.xhtml:11:78 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/logging-cookbook.xhtml:11:62 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/logging.xhtml:11:62 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/howto/regex.xhtml:11:64 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.4.xhtml:11:66 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.5.xhtml:11:71 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.6.xhtml:11:71 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.
FATAL - RSC-016 - Python.epub/whatsnew/3.7.xhtml:11:70 - Fatal Error while parsing file: The value of attribute "content" associated with an element type "meta" must not contain the '<' character.

https://github.com/python/cpython/actions/runs/16706217793/job/47284695629?pr=137342

This PR:

Run python Doc/tools/check-epub.py

https://github.com/python/cpython/actions/runs/16708070077/job/47288978290?pr=137348

In a separate PR, we can now make the EPUB error check required to pass to prevent regressions, and also add some sort of "No errors found" for the success case rather than no output.

@AA-Turner AA-Turner merged commit 13e21b2 into python:main Aug 3, 2025
40 checks passed
@AA-Turner AA-Turner deleted the docs/opengraph-0.11 branch August 3, 2025 18:32
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2025
(cherry picked from commit 13e21b2fd6343ba8309ed857a2cbf6d6995ca5f2)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2025
(cherry picked from commit 13e21b2)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 3, 2025

GH-137349 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 3, 2025

GH-137350 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 3, 2025
hugovk pushed a commit that referenced this pull request Aug 3, 2025
…37349)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request Aug 3, 2025
…37350)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner
Copy link
Member Author

In a separate PR, we can now make the EPUB error check required to pass to prevent regressions, and also add some sort of "No errors found" for the success case rather than no output.

See #137351.

A

@hugovk
Copy link
Member

hugovk commented Aug 3, 2025

Like #136406, I expect we'll also need a 3.12 backport.

We can wait for confirmation these changes result in a working EPUB for the newer branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy